Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CTPPS: bug fix #2 in run ranges for FEDs channels mapping (9_1_X) #18733

Closed

Conversation

forthommel
Copy link
Contributor

@forthommel forthommel commented May 15, 2017

Forward-port of #18732 onto 9_1_X.

Proper handling of the begin/end conditions through the usage of a edm::contains (instead of a home-brewed check).

runTheMatrix.py -l limited on 0dbffaa yielded 17 17 15 13 6 0 0 0 tests passed, 1 0 1 0 0 0 0 0 failedwith the usual step0 DAS error on 4.22, and a return code 35072 for step2 of 1001.0

@forthommel forthommel changed the title CTPPS: bug fix #2 in run ranges for FEDs channels mapping (9_1_X) CTPPS: bug fix #2 in run ranges for FEDs channels mapping (9_1_X) May 15, 2017
@cmsbuild cmsbuild added this to the CMSSW_9_1_X milestone May 15, 2017
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @forthommel (Laurent Forthomme) for CMSSW_9_1_X.

It involves the following packages:

CondFormats/CTPPSReadoutObjects

@ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @ggovi, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @tocheng this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@slava77
Copy link
Contributor

slava77 commented May 15, 2017

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 15, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19856/console Started: 2017/05/16 00:31

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18733/19856/summary.html

Comparison Summary:

  • You potentially added 63 lines to the logs
  • Reco comparison results: 1634 differences found in the comparisons
  • DQMHistoTests: Total files compared: 24
  • DQMHistoTests: Total histograms compared: 1831084
  • DQMHistoTests: Total failures: 25142
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 1805761
  • DQMHistoTests: Total skipped: 180
  • DQMHistoTests: Total Missing objects: 0
  • Checked 98 log files, 14 edm output root files, 24 DQM output files

@ggovi
Copy link
Contributor

ggovi commented May 16, 2017

+1

@davidlange6
Copy link
Contributor

Closing PR. CMSSW_9_1_X is for muon TDR upgrade changes only (CMSSW_9_2_X for data taking)

@forthommel forthommel deleted the ctpps-runranges_patch2-9_1_X branch May 17, 2017 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants