Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove HF/Voronoi subtraction for jets in heavy ions and disable centrality bin producer #18684

Merged
merged 5 commits into from
May 20, 2017
Merged

Remove HF/Voronoi subtraction for jets in heavy ions and disable centrality bin producer #18684

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a91c641
Remove HF-Voronoi subtraction for jets in heavy ions and disable cent…
mandrenguyen May 10, 2017
44fb147
Update CentralityDQM.cc
mandrenguyen May 17, 2017
dd7574a
Update JetAnalyzer_HeavyIons.cc
mandrenguyen May 17, 2017
8cbb255
Update JetTester_HeavyIons.cc
mandrenguyen May 17, 2017
4b28124
cleanup of externals and logs
mandrenguyen May 18, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DQM/Physics/src/CentralityDQM.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ void CentralityDQM::analyze(const edm::Event& iEvent,
if(cent.isValid()){
int hibin = -999;
if(cbin.isValid()) hibin = *cbin;
else edm::LogWarning("CentralityDQM") << "invalid collection: centralityBin " << std::endl;
//else edm::LogWarning("CentralityDQM") << "invalid collection: centralityBin " << std::endl;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this commented out code needed?
Please remove or add comments inline in the code why the commented out block is relevant

... BTW, these LogWarnings was just the first comment/topic from reco review, I'm not done yet.


// std::cout<< " ------------------------------------- " << hibin << std::endl;

Expand Down
2 changes: 1 addition & 1 deletion DQMOffline/JetMET/src/JetAnalyzer_HeavyIons.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -803,7 +803,7 @@ void JetAnalyzer_HeavyIons::analyze(const edm::Event& mEvent, const edm::EventSe
if(cbin.isValid()){
hibin = *cbin;
}
else edm::LogWarning("JetAnalyzer_HeavyIons") << "invalid collection: centralityBin " << std::endl;
//else edm::LogWarning("JetAnalyzer_HeavyIons") << "invalid collection: centralityBin " << std::endl;

const reco::PFCandidateCollection *pfCandidateColl = pfCandidates.product();

Expand Down
2 changes: 1 addition & 1 deletion Validation/RecoJets/plugins/JetTester_HeavyIons.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -737,7 +737,7 @@ void JetTester_HeavyIons::analyze(const edm::Event& mEvent, const edm::EventSetu
if(cbin.isValid()){
hibin = *cbin;
}
else edm::LogWarning("JetTester_HeavyIons") << "invalid collection: centralityBin " << std::endl;
//else edm::LogWarning("JetTester_HeavyIons") << "invalid collection: centralityBin " << std::endl;

bool isCentral = false;
bool ismidCentral = false;
Expand Down