Stop compiler warning for CaloCluster's operator<< #18530
Conversation
gcc6 warned that operator<< for CaloCluster was not in the reco namespace.
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: DataFormats/CaloRecHit @perrotta, @cmsbuild, @slava77, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
cmsbuild
added
fully-signed
reconstruction-approved
and removed
pending-signatures
reconstruction-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
|
Hi @Dr15Jones - having tried to fix this once.. do you need to remove lines 201-202? friend std::ostream& operator<<(std::ostream& out, |
| @@ -25,6 +25,9 @@ | |||
|
|
|||
| namespace reco { | |||
|
|
|||
| class CaloCluster; | |||
| std::ostream& operator<<(std::ostream& out, | |||
There was a problem hiding this comment.
will it be visible globally or is it a reco::operator<< here?
There was a problem hiding this comment.
It is reco::operator<< there. But the way C++ looks up free functions, it will look for it in the same namespace as CaloCluster.
|
+1 |
gcc6 warned that operator<< for CaloCluster was not in the reco
namespace.