Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid copy of the whole dig collection #18526

Merged
merged 4 commits into from
May 2, 2017

Conversation

VinInn
Copy link
Contributor

@VinInn VinInn commented Apr 30, 2017

URGENT. takes longer that line than the whole reco-dqm

took the opportunity to fix a similar bug in pixel (phase1, but apparently running on 2016 data as well...)

@cmsbuild cmsbuild added this to the Next CMSSW_9_1_X milestone Apr 30, 2017
@VinInn
Copy link
Contributor Author

VinInn commented Apr 30, 2017

type bug-fix

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @VinInn (Vincenzo Innocente) for master.

It involves the following packages:

DQM/SiStripMonitorTrack

@cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@idebruyn, @threus, @fioriNTU, @hdelanno this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@VinInn
Copy link
Contributor Author

VinInn commented Apr 30, 2017

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 30, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19478/console Started: 2017/04/30 15:31

@cmsbuild
Copy link
Contributor

Pull request #18526 was updated. @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please check and sign again.

@cmsbuild
Copy link
Contributor

Pull request #18526 was updated. @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please check and sign again.

@VinInn
Copy link
Contributor Author

VinInn commented Apr 30, 2017

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 30, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19479/console Started: 2017/04/30 15:56

@VinInn
Copy link
Contributor Author

VinInn commented Apr 30, 2017

@fioriNTU @boudoul @veszpv FYI

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Pull request #18526 was updated. @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please check and sign again.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18526/19479/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 1680 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 1778687
  • DQMHistoTests: Total failures: 52869
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1725645
  • DQMHistoTests: Total skipped: 173
  • DQMHistoTests: Total Missing objects: 0
  • Checked 94 log files, 14 edm output root files, 23 DQM output files

@VinInn
Copy link
Contributor Author

VinInn commented May 1, 2017

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 1, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19480/console Started: 2017/05/01 09:51

@cmsbuild
Copy link
Contributor

cmsbuild commented May 1, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented May 1, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 1, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18526/19480/summary.html

Comparison Summary:

  • You potentially added 59 lines to the logs
  • Reco comparison results: 3360 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 1778721
  • DQMHistoTests: Total failures: 47584
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1730964
  • DQMHistoTests: Total skipped: 173
  • DQMHistoTests: Total Missing objects: 0
  • Checked 94 log files, 14 edm output root files, 23 DQM output files

@davidlange6
Copy link
Contributor

Thanks...

@davidlange6 davidlange6 merged commit f0c2400 into cms-sw:master May 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants