Ecalpedestal pcl improved #18512
Ecalpedestal pcl improved #18512
Conversation
|
A new Pull Request was created by @argiro for master. It involves the following packages: Calibration/EcalCalibAlgos @ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
can this be reviewed and hopefully integrated soon ? We are looking forward to a backport to be able to deploy the PCL in data taking asap.
thanks
… On 28 Apr 2017, at 21:30, cmsbuild ***@***.***> wrote:
Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18512/19464/summary.html
Comparison Summary:
• No significant changes to the logs found
• Reco comparison results: 95 differences found in the comparisons
• DQMHistoTests: Total files compared: 23
• DQMHistoTests: Total histograms compared: 1778687
• DQMHistoTests: Total failures: 46416
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 1732098
• DQMHistoTests: Total skipped: 173
• DQMHistoTests: Total Missing objects: 0
• Checked 94 log files, 14 edm output root files, 23 DQM output files
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
| uint32_t pedestalSamples_ ; // number of presamples to be used for pedestal determination | ||
| bool checkSignal_; // avoid frames containing a signal | ||
| uint32_t sThreshold_ ; // if checkSignal = true threshold (in adc count) above which we'll assume | ||
| // there's signal and not just pedestal |
There was a problem hiding this comment.
hello @argiro
With the noise being significantly different between EB and EE (factor 2-3),
and somewhat |eta| dependent in EE
the significance to have "signal" in EB and EE dataframes
could be set here in relative terms in units of of sigma's of the noise
and the check carried out against Numsigna's x sigma_in_db
|
no unexpected changes in the relval-based workflows |
cmsbuild
added
comparison-pending
tests-pending
and removed
comparison-available
tests-approved
labels
|
I've updated the branch with separate threshold parameters for EB and EE
… On 2 May 2017, at 16:52, Giovanni Franzoni ***@***.***> wrote:
no unexpected changes in the relval-based workflows
can be signed once we agree on the matter I've commented about above
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
cmsbuild
added
alca-pending
comparison-pending
pending-signatures
tests-pending
and removed
tests-approved
labels
|
done
… On 3 May 2017, at 09:26, David Lange ***@***.***> wrote:
@davidlange6 commented on this pull request.
In Calibration/EcalCalibAlgos/src/ECALpedestalPCLHarvester.cc:
> @@ -141,3 +152,39 @@ bool ECALpedestalPCLHarvester::checkStatusCode(const DetId& id){
return true;
}
+
+
+bool ECALpedestalPCLHarvester::checkVariation(const EcalPedestalsMap& oldPedestals,
+ const EcalPedestalsMap& newPedestals) {
+
+ uint32_t nAnomaliesEB =0;
+ uint32_t nAnomaliesEE =0;
+
+ for (uint16_t i =0; i< EBDetId::kSizeForDenseIndexing; ++i) {
+
+ DetId id = EBDetId::detIdFromDenseIndex(i);
+ const EcalPedestal& newped=* newPedestals.find(id.rawId());
+ const EcalPedestal& oldped=* oldPedestals.find(id.rawId());
+
+ if (abs(newped.mean_x12 -oldped.mean_x12) > nSigma_ * oldped.rms_x12) nAnomaliesEB++;
hi @argiro - please use std:abs.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
+1 |
|
please test |
|
The tests are being triggered in jenkins. |
cmsbuild
added
alca-approved
fully-signed
and removed
alca-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
Adding flexibility:
changed default on channels to be excluded