remove tmp patch in the configuration of association thresholds for P…

[abbiendi]

Fix the configuration for phase2 New muon validation, removing the previous temporary patch.
This restores the desired defaults and is possible after the integration of the fix to the TrackerHitAssociator (PR #18354).
Git could not take that PR as wished (the file NewAssociators_cff.py was the wanted one in the submitted branch) as there was a previous PR (#18290 ) branched from the same base release which was integrated previously, containing the temporary patch, so it had to be expected. I realized it after checking the latest IB. sorry...

[cmsbuild]

A new Pull Request was created by @abbiendi for master.

It involves the following packages:

Validation/RecoMuon

@cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@battibass, @jhgoh, @calderona, @HuguesBrun, @trocino, @rociovilar this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here

[abbiendi]

this is a very simple fix, is it possible to move on with it ?

[dmitrijus]

+1

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19542/console Started: 2017/05/03 14:47

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

[cmsbuild]

+1
Tested at: 81e967a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18511/19542/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18511/19542/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 3346 differences found in the comparisons
• DQMHistoTests: Total files compared: 24
• DQMHistoTests: Total histograms compared: 1835853
• DQMHistoTests: Total failures: 31516
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 1804156
• DQMHistoTests: Total skipped: 180
• DQMHistoTests: Total Missing objects: 0
• Checked 98 log files, 14 edm output root files, 24 DQM output files

[abbiendi]

Hi, about the above comparison summary: there cannot be any sensible difference if (as I assume) the tested workflows are just the standard ones, given that this change touches only the New muon validation, which has to be enabled by a customization.

[fabiocos]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25441/console Started: 2018/01/15 11:05

[abbiendi]

@fabiocos
Hi Fabio, sorry this is an old pr which should be closed (I do not know why it survived so long, I did not even know about it)
This fix is already contained in the merged PR #20701.

[cmsbuild]

+1
Tested at: 81e967a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18511/25441/summary.html

[cmsbuild]

Comparison job queued.

[abbiendi]

please do not merge it. I fear it might spoil the other updates in PR #20701.
This is an obsolete leftover, it had to be removed from the list of pending items, instead it got propagated through many releases (you can see it: it came from CMSSW_9_1_X).

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18511/25441/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-18511/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 26
• DQMHistoTests: Total histograms compared: 2467599
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2467429
• DQMHistoTests: Total skipped: 169
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 1.01999999971 KiB( 22 files compared)
• Checked 110 log files, 9 edm output root files, 26 DQM output files