Run2-TB29 Add beam chamber information in the Analyzer

[bsunanda]

Make the DetID code for beam chamber decoupled from the SD class

[bsunanda]

@cmsbuild Please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19455/console Started: 2017/04/28 13:03

[cmsbuild]

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

SimDataFormats/CaloTest
SimDataFormats/HcalTestBeam
SimG4CMS/HGCalTestBeam
SimG4CMS/HcalTestBeam

@cmsbuild, @civanch, @mdhildreth, @kpedro88, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

[cmsbuild]

+1
Tested at: a0f14ed
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18510/19455/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18510/19455/summary.html

Comparison Summary:

• You potentially added 23 lines to the logs
• Reco comparison results: 1767 differences found in the comparisons
• DQMHistoTests: Total files compared: 23
• DQMHistoTests: Total histograms compared: 1778687
• DQMHistoTests: Total failures: 37569
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 1740945
• DQMHistoTests: Total skipped: 173
• DQMHistoTests: Total Missing objects: 0
• Checked 94 log files, 14 edm output root files, 23 DQM output files

[civanch]

+1

[bsunanda]

@kpedro88 Please approve this

[kpedro88]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar