-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix forward declaration of RefHolderBase in wrong namespace. #18416
Fix forward declaration of RefHolderBase in wrong namespace. #18416
Conversation
RefHolderBase is in the namespace edm::reftobase, but it was forward declared in namespace edm. This could cause a compilation error when instantiating this template under some circumstances. This patch moves the forward declaration to the correct namespace.
Part of #15248 |
A new Pull Request was created by @Teemperor (Raphael Isemann) for master. It involves the following packages: DataFormats/Common @cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar |
Comparison is ready Comparison Summary:
|
RefHolderBase is in the namespace edm::reftobase, but it was
forward declared in namespace edm. This could cause a compilation
error when instantiating this template under some circumstances (such
as when we compile the header into a module).
This patch moves the forward declaration to the correct namespace.