-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Making Puppi optional for PATPackedCandidate producer : 80X #16776
Conversation
A new Pull Request was created by @Sam-Harper for CMSSW_8_0_X. It involves the following packages: PhysicsTools/PatAlgos @cmsbuild, @cvuosalo, @slava77, @monttj, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
@cmsbuild please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
@cmsbuild please test |
Comparison job queued. |
@cmsbuild please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
+1 Provide the option to run the PAT PackedCandidate producer without PUPPI. Default behavior does not change. There should be no change in monitored quantities. #16777 and #16778 are the 90X and 81X versions of this PR, and the former has been approved by Reco. The code changes are satisfactory, and Jenkins tests against baseline CMSSW_8_0_X_2016-12-07-0000 show no significant differences, as expected. |
+1 |
This commit makes puppi inputs optional for PATPackedCandidateProducer. If the puppi related input tags are both empty, it disables accessing puppi. If the input tags not empty, the behaviour is identical to before, thereby protecting against simple typos.
This is helpful to remake the PFPackedCandidates without running all of miniAOD. The use case which prompts this is the new HEEP V7.0 uses PFPackedCandidates for tracker isolation and therefore needs to produce these in AOD.
81X and 90X PRs following shortly.