fix crash in case Limit on the number of clusters is really exceeded.

[VinInn]

back port of #14661

@fwyzard

[VinInn]

@cmsbuild , please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13236/console

[cmsbuild]

A new Pull Request was created by @VinInn (Vincenzo Innocente) for CMSSW_8_0_X.

It involves the following packages:

RecoLocalTracker/SiPixelClusterizer

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @GiacomoSguazzoni, @rovere, @VinInn, @dkotlins, @gpetruc, @threus this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

[fwyzard]

@VinInn thanks for the quick fix and for the backport.

@cvuosalo, @slava77, could you quickly review and sign ?

@davidlange6 , once all tests and signatures are OK, could you build an 8.0.8 patch release with this fix ?

Thank you,
.Andrea

[slava77]

this looks simple enough.
I'd wait for jenkins results and then sign.

[cmsbuild]

+1
Tested at: 7ed8ff9
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14662/13236/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14662/13236/summary.html

[slava77]

+1

for #14662 7ed8ff9

• limits the lifetime of FastFiller spc to avoid overwrites to timely tell that the filled DetSet is not being filled anymore (m_filling=false) and with this also avoid a crash in DetSetVector::swap call
• jenkins tests pass and comparisons with baseline show no difference (none expected in single-thread "normal" inputs)

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

[davidlange6]

+1

On 27 May 2016, at 19:51, cmsbuild <notifications@github.commailto:notifications@github.com> wrote:

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77https://github.com/slava77, @davidlange6https://github.com/davidlange6, @deganohttps://github.com/degano, @smuzaffarhttps://github.com/smuzaffar

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com//pull/14662#issuecomment-222211312, or mute the threadhttps://github.com/notifications/unsubscribe/AEzyw1uv0wxFyOWROAs0vwrMLT5FSuAaks5qFy8MgaJpZM4IoiZ1.