Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore overflow check for et and ht sums #14650

Merged
merged 1 commit into from
May 27, 2016
Merged

Restore overflow check for et and ht sums #14650

merged 1 commit into from
May 27, 2016

Conversation

mulhearn
Copy link
Contributor

This restores overflow checks to the L1T Calo sums, to match firmware.

@cmsbuild cmsbuild added this to the Next CMSSW_8_0_X milestone May 26, 2016
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mulhearn for CMSSW_8_0_X.

It involves the following packages:

L1Trigger/L1TCalorimeter

@cmsbuild, @rekovic, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@mulhearn mulhearn mentioned this pull request May 26, 2016
Open
@mulhearn mulhearn force-pushed the pr-l1t-sum-overflow branch from 22d6463 to 8ae610d Compare May 27, 2016 00:58
@mulhearn
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 27, 2016 •
edited
Loading

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13224/console

@mulhearn mulhearn mentioned this pull request May 27, 2016
Merged
@mulhearn mulhearn changed the title Restore overflow check to L1T calo sums Restore overflow check for et and ht sums May 27, 2016
@cmsbuild
Copy link
Contributor

+1
Tested at: 8ae610d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14650/13224/summary.html

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14650/13224/summary.html

@mulhearn
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit bb076d2 into cms-sw:CMSSW_8_0_X May 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available fully-signed l1-approved orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_8_0_X
Development

Successfully merging this pull request may close these issues.
3 participants
@mulhearn @cmsbuild @davidlange6