-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PCL SiPixel Alignment: integration of quality checks on payload and DQM module #13984
Conversation
… booking and filling
A new Pull Request was created by @cerminar for CMSSW_8_1_X. It involves the following packages: Alignment/CommonAlignmentProducer @cmsbuild, @mmusich, @franzoni, @cerminar, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
please test |
The tests are being triggered in jenkins. |
|
||
int det = -1; | ||
|
||
if (alignable >= 60 && alignable <= 69) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ghellwig for the sake of curiosity how is the millepede internal labeling going to behave with the phase-I geometry?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mmusich I think, as long as the number of alignables does not exceed 700000 we are fine:
Haven't checked it, though.
Ops, this PR was obviously meant for 80X since there is already one in 81X, sorry for the noise. |
This PR modifies only the PCL sequences for the alignment of the Pixel large structures.
It integrates the needed checks for the creation of the payload and the DQM module to monitor the movements of the alignables.
This is needed to start testing the new workflow in production environment.
This is equivalent to PR #13983 for 81X.