Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup of EG HLT filters #13845

Closed
wants to merge 2 commits into from
Closed

Conversation

afiqaize
Copy link
Contributor

Hi,

This is exactly the same as PR #13844 but for 80X.

Best regards,
Afiq

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @afiqaize (Afiq Anuar) for CMSSW_8_0_X.

It involves the following packages:

HLTrigger/Egamma

@Martin-Grunewald, @perrotta, @cmsbuild, @fwyzard, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@Martin-Grunewald
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12075/console

@cmsbuild
Copy link
Contributor

-1
Tested at: a6c9c81
When I ran the RelVals I found an error in the following worklfows:
134.911 step2

runTheMatrix-results/134.911_RunSinglePh2015D+RunSinglePh2015D+HLTDR2_25ns+RECODR2_25nsreHLT+HARVESTDR2_25nsreHLT/step2_RunSinglePh2015D+RunSinglePh2015D+HLTDR2_25ns+RECODR2_25nsreHLT+HARVESTDR2_25nsreHLT.log
----- Begin Fatal Exception 27-Mar-2016 07:55:12 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Validating configuration of module: class=HLTEgammaEtFilter label='hltEle24Ele22leg1EtFilter'
Exception Message:
Illegal parameters found in configuration.  The parameters are named:
 'L1IsoCand'
 'L1NonIsoCand'
 'relaxed'
You could be trying to use parameter names that are not
allowed for this plugin or they could be misspelled.
----- End Fatal Exception -------------------------------------------------

1306.0 step2

runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/step2_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log
----- Begin Fatal Exception 27-Mar-2016 07:59:14 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Validating configuration of module: class=HLTEgammaEtFilter label='hltEle24Ele22leg1EtFilter'
Exception Message:
Illegal parameters found in configuration.  The parameters are named:
 'L1IsoCand'
 'L1NonIsoCand'
 'relaxed'
You could be trying to use parameter names that are not
allowed for this plugin or they could be misspelled.
----- End Fatal Exception -------------------------------------------------

135.4 step1

runTheMatrix-results/135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS/step1_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS.log
----- Begin Fatal Exception 27-Mar-2016 08:01:59 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Validating configuration of module: class=HLTEgammaEtFilter label='hltEle24Ele22leg1EtFilter'
Exception Message:
Illegal parameters found in configuration.  The parameters are named:
 'L1IsoCand'
 'L1NonIsoCand'
 'relaxed'
You could be trying to use parameter names that are not
allowed for this plugin or they could be misspelled.
----- End Fatal Exception -------------------------------------------------

1330.0 step2

runTheMatrix-results/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15/step2_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15.log
----- Begin Fatal Exception 27-Mar-2016 08:07:19 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Validating configuration of module: class=HLTEgammaEtFilter label='hltEle24Ele22leg1EtFilter'
Exception Message:
Illegal parameters found in configuration.  The parameters are named:
 'L1IsoCand'
 'L1NonIsoCand'
 'relaxed'
You could be trying to use parameter names that are not
allowed for this plugin or they could be misspelled.
----- End Fatal Exception -------------------------------------------------

25202.0 step2

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step2_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log
----- Begin Fatal Exception 27-Mar-2016 08:15:58 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Validating configuration of module: class=HLTEgammaEtFilter label='hltEle24Ele22leg1EtFilter'
Exception Message:
Illegal parameters found in configuration.  The parameters are named:
 'L1IsoCand'
 'L1NonIsoCand'
 'relaxed'
You could be trying to use parameter names that are not
allowed for this plugin or they could be misspelled.
----- End Fatal Exception -------------------------------------------------

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13845/12075/summary.html

@Martin-Grunewald
Copy link
Contributor

@afiqaize
Please post a JIRA ticket with the translation mapping of the old parameter values to the new parameter values. I assume just to get it to run we just need the changes at module level.
In a later step there is presumably a simplification of many sequences and paths, now that only one collection instead of two has to be constructed and filtered upon.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2016

Pull request #13845 was updated. @Martin-Grunewald, @perrotta, @cmsbuild, @fwyzard, @davidlange6 can you please check and sign again.

Martin-Grunewald added a commit to cms-tsg-storm/cmssw that referenced this pull request May 10, 2016
Martin-Grunewald added a commit to cms-tsg-storm/cmssw that referenced this pull request May 10, 2016
@cmsbuild
Copy link
Contributor

Pull request #13845 was updated. @perrotta, @cmsbuild, @dmitrijus, @Martin-Grunewald, @deguio, @fwyzard, @vanbesien, @davidlange6 can you please check and sign again.

Martin-Grunewald added a commit to cms-tsg-storm/cmssw that referenced this pull request May 11, 2016
Martin-Grunewald added a commit to cms-tsg-storm/cmssw that referenced this pull request May 11, 2016
Martin-Grunewald added a commit to cms-tsg-storm/cmssw that referenced this pull request May 12, 2016
Martin-Grunewald added a commit to cms-tsg-storm/cmssw that referenced this pull request May 13, 2016
Martin-Grunewald added a commit to cms-tsg-storm/cmssw that referenced this pull request May 13, 2016
Martin-Grunewald added a commit to cms-tsg-storm/cmssw that referenced this pull request May 18, 2016
Martin-Grunewald added a commit to cms-tsg-storm/cmssw that referenced this pull request May 24, 2016
@Martin-Grunewald
Copy link
Contributor

@afiqaize
This is now integrated through #14445 so please close this PR.

@afiqaize afiqaize closed this May 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants