Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fastsim: cleanup HLT configuration #13032

Merged
merged 4 commits into from
Jan 25, 2016
Merged

Fastsim: cleanup HLT configuration #13032

merged 4 commits into from
Jan 25, 2016

Conversation

lveldere
Copy link
Contributor

Remove a bunch of files and modules that are no longer used.
Change a few filenames and module names to make clear they belong to hlt.

@lveldere
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10678/console

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @lveldere for CMSSW_8_0_X.

It involves the following packages:

FastSimulation/Configuration
FastSimulation/EgammaElectronAlgos
FastSimulation/HighLevelTrigger
FastSimulation/Tracking
HLTrigger/Configuration

@perrotta, @cmsbuild, @civanch, @lveldere, @ssekmen, @mdhildreth, @Martin-Grunewald, @fwyzard, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @matt-komm, @geoff-smith, @jalimena this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@Martin-Grunewald
Copy link
Contributor

-1

Error in FastSim:

----- Begin Fatal Exception 22-Jan-2016 13:00:13 CET-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing run: 1 lumi: 1 event: 7
   [1] Running path 'HLT_Mu7p5_Track2_Jpsi_v2'
   [2] Calling event method for module PixelVertexProducer/'hltPixelVerticesL3Muon'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: std::vector<reco::Track>
Looking for module label: hltPixelTracks
Looking for productInstanceName:

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------

@lveldere
Copy link
Contributor Author

Weird, I thought I fixed that.
Can you send me the cmsDriver command?

On Fri, Jan 22, 2016 at 1:02 PM, Martin Grunewald notifications@github.com
wrote:

-1

Error in FastSim:

----- Begin Fatal Exception 22-Jan-2016 13:00:13 CET-----------------------
An exception of category 'ProductNotFound' occurred while
[0] Processing run: 1 lumi: 1 event: 7
[1] Running path 'HLT_Mu7p5_Track2_Jpsi_v2'
[2] Calling event method for module PixelVertexProducer/'hltPixelVerticesL3Muon'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: std::vectorreco::Track
Looking for module label: hltPixelTracks
Looking for productInstanceName:

Additional Info:
[a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------


Reply to this email directly or view it on GitHub
#13032 (comment).

@Martin-Grunewald
Copy link
Contributor

800pre5 + PR +

# Auto generated configuration file
# using: 
# Revision: 1.19 
# Source: /local/reps/CMSSW/CMSSW/Configuration/Applications/python/ConfigBuilder.py,v 
# with command line options: TTbar_Tauola_13TeV_cfi --step=GEN,SIM,RECOBEFMIX,DIGI,L1,L1Reco,RECO,HLT:GRun --fast --conditions=auto:run2_mc_GRun --custom_conditions= --fileout=FastSim_GenToHLT_GRun_MC.root --number=100 --mc --no_exec --datatier GEN-SIM-DIGI-RECO --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era=Run2_25ns --customise= --scenario=pp --python_filename=FastSim_GenToHLT_GRun_MC.py --processName=HLT

@cmsbuild
Copy link
Contributor

-1

Tested at: 9aad073
I found errors in the following addon tests:

cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,L1Reco,RECO,EI,HLT:@relval25ns,VALIDATION --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_25ns --magField 38T_PostLS1 : FAILED - time: date Fri Jan 22 13:38:00 2016-date Fri Jan 22 13:28:25 2016 s - exit: 16640

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13032/10678/summary.html

@lveldere
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

Pull request #13032 was updated. @perrotta, @cmsbuild, @civanch, @lveldere, @ssekmen, @mdhildreth, @Martin-Grunewald, @fwyzard, @davidlange6 can you please check and sign again.

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10680/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@lveldere
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

@Martin-Grunewald
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Jan 25, 2016
Fastsim: cleanup HLT configuration
@cmsbuild cmsbuild merged commit 9ce53be into cms-sw:CMSSW_8_0_X Jan 25, 2016
@lveldere lveldere deleted the fastsim-hltcfg branch January 25, 2016 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants