Remove vestigial (and huge) GBRForest when running with PFEGAlgo (74X)

[lgray]

Backport of #10315

[cmsbuild]

A new Pull Request was created by @lgray (Lindsey Gray) for CMSSW_7_4_X.

Remove vestigial (and huge) GBRForest when running with PFEGAlgo (74X)

It involves the following packages:

RecoParticleFlow/PFProducer

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@mmarionncern, @bachtis this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.

[lgray]

@slava77 I think the cmsbuild job died here. Probably need to start a new one.

[cvuosalo]

@cmsbuild please test
Try again

[cvuosalo]

Memory usage test in progress...

[lgray]

@slava77 @cvuosalo Hi guys, I don't see this queued in jenkins. May want to ask again for tests.

[slava77]

@cmsbuild please test

[smuzaffar]

tests are running now
On 07/27/2015 04:03 PM, Lindsey Gray wrote:

@slava77 https://github.com/slava77 @cvuosalo
https://github.com/cvuosalo Hi guys, I don't see this queued in
jenkins. May want to ask again for tests.

—
Reply to this email directly or view it on GitHub
#10319 (comment).

[cmsbuild]

+1
Tested at: 48af6ea
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10319/6635/summary.html

[cvuosalo]

+1

For #10319 48af6ea

Removing unneeded GBRForest when running with PFEGAlgo. As seen for the 76X version of this PR, #10315, there should be about a 100 MB reduction in memory use. Otherwise, there should be no change in monitored quantities.

The code changes are satisfactory, and Jenkins tests against baseline CMSSW_7_4_X_2015-07-24-2300 show no significant differences, as expected. A test of workflow 25202.0_TTbar_13 with 70 events against baseline CMSSW_7_4_X_2015-07-21-2300 also shows no significant differences, and memory measurement shows about a 60 MB drop in RSS:

Baseline
Max VSIZ 3791.49 on evt 54 ; max RSS 3174.82 on evt 45
Time av 82.9808 s/evt max 117.11 s on evt 34

PR 10319
Max VSIZ 3701.99 on evt 38 ; max RSS 3116.48 on evt 45
Time av 86.5668 s/evt max 116.874 s on evt 20

Note that, in this test, RECO included DQM and Validation.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[davidlange6]

+1