-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve LHEReader IO (and optimize skipping events) #10287
Conversation
A new Pull Request was created by @bbockelm (Brian Bockelman) for CMSSW_7_1_X. Improve LHEReader IO (and optimize skipping events) It involves the following packages: GeneratorInterface/LHEInterface @vciulli, @cmsbuild, @covarell, @bendavid, @thuer can you please review it and eventually sign? Thanks. |
} | ||
buffLoc_=0; | ||
buffTotal_=rd; | ||
std::cout << "Total buffer data read: " << buffTotal_ << std::endl; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This cout should probably be removed.
Good catch - development cout's removed. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs once checked with relvals in the development release cycle of CMSSW or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
Improve LHEReader IO (and optimize skipping events)
@bendavid @davidlange6 - should I do another PR for 7_6_X? |
Did it already |
Thanks! Is there any final summary of the performance improvements? I know the real world sometimes differs from my development VM. I suppose just giving me a heads-up when the affected SUSY LHE gets resubmitted. |
This branch does two things:
When testing (2), I found there was 1.8x speedup when reading compressed files and 1.9x speedup when reading uncompressed files. This suggests, when there is efficient IO, we are dominated by XML parsing times (not decompression times).
@davidlange6 @bendavid