Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport stage1 unpacker to 74x #10234

Merged

Conversation

mulhearn
Copy link
Contributor

This is the 74X backport of #10163.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mulhearn for CMSSW_7_4_X.

backport stage1 unpacker to 74x

It involves the following packages:

EventFilter/L1TRawToDigi
HLTrigger/Configuration
L1Trigger/L1TCommon

The following packages do not have a category, yet:

EventFilter/L1TRawToDigi

@Martin-Grunewald, @perrotta, @cmsbuild, @mulhearn, @fwyzard can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @geoff-smith, @jalimena this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mulhearn
Copy link
Contributor Author

please test

@Martin-Grunewald
Copy link
Contributor

What about 75X?

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

Pull request #10234 was updated. @Martin-Grunewald, @perrotta, @cmsbuild, @mulhearn, @fwyzard can you please check and sign again.

@mulhearn
Copy link
Contributor Author

Coming next.... isn't it easier to work forward?

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@davidlange6
Copy link
Contributor

whoops - my last comment in #10463 was meant for this - changes to 25ns MC that can not be avoided.

davidlange6 added a commit that referenced this pull request Aug 1, 2015
@davidlange6 davidlange6 merged commit 3a1bd38 into cms-sw:CMSSW_7_4_X Aug 1, 2015
@mulhearn mulhearn deleted the l1t-stage1unpacker-74x branch January 25, 2016 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants