ngrenz Strip Validation Package Optimization

[ngrenz]

PR of a work intended to optimize gradually the performance of tracker validation code.
Here I tried to resolve the “FIXME: vector is Suboptimal “.
Outputs are supposed to be unchanged.

The changes are:

• Instead of one big loop over the DetIds, we have 3 loops over rechits-rphi, -stereo and -matched
• We do not need the vector for DetIds and we do not need to fill this vector
• The compute where we are in the vector is now unnecessary
• The computing of rechitpro and the use with fillME is now in the same loops
• We do not need some vectors for the value transfers

Any comments and suggestions are welcome.
More optimizations will follow.

[ngrenz]

@boudoul FYI

[cmsbuild]

A new Pull Request was created by @ngrenz for CMSSW_7_6_X.

Cmssw 7 5 0 pre6 ngrenz SiStripRecHitsValid

It involves the following packages:

Validation/TrackerRecHits

@cmsbuild, @danduggan, @deguio can you please review it and eventually sign? Thanks.
@VinInn, @threus, @wmtford this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[boudoul]

Hi @ngrenz , could you please change the title "Cmssw 7 5 0 pre6 ngrenz SiStripRecHitsValid" of your PR with something like "Strip Validation Package Optimization " (the title is what is propagated to the release notes, and help anyone understanding what is entering in a release) - Thanks

[deguio]

please test

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

-1
Tested at: 36e0896
I found an error when building:

>> Building shared library tmp/slc6_amd64_gcc491/src/DQMServices/Core/src/DQMServicesCore/libDQMServicesCore.so
Copying tmp/slc6_amd64_gcc491/src/DQMServices/Core/bin/DQMCollector/DQMCollector to productstore area:
/afs/cern.ch/cms/sw/ReleaseCandidates/volC/slc6_amd64_gcc491/external/gcc/4.9.1-cms/bin/../lib/gcc/x86_64-redhat-linux-gnu/4.9.1/../../../../x86_64-redhat-linux-gnu/bin/ld: cannot find -lFWCoreFramework
/afs/cern.ch/cms/sw/ReleaseCandidates/volC/slc6_amd64_gcc491/external/gcc/4.9.1-cms/bin/../lib/gcc/x86_64-redhat-linux-gnu/4.9.1/../../../../x86_64-redhat-linux-gnu/bin/ld: cannot find -lDataFormatsCommon
/afs/cern.ch/cms/sw/ReleaseCandidates/volC/slc6_amd64_gcc491/external/gcc/4.9.1-cms/bin/../lib/gcc/x86_64-redhat-linux-gnu/4.9.1/../../../../x86_64-redhat-linux-gnu/bin/ld: cannot find -lDataFormatsStdDictionaries
collect2: error: ld returned 1 exit status
gmake: **\* [tmp/slc6_amd64_gcc491/src/DQMServices/Core/src/DQMServicesCore/libDQMServicesCore.so] Error 1
>> Leaving Package FWCore/Version
>> Package FWCore/Version built
Leaving library rule at DQMServices/Core
>> Subsystem FWCore built


you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10232/6268/summary.html

[deguio]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[davidlange6]

+1