Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

point seeded tracking regions (backport PR #9149) #10225

Merged

Conversation

mtosi
Copy link
Contributor

@mtosi mtosi commented Jul 15, 2015

this PR is needed to make use of the point seeded tracking region
which might be very useful in order to cope w/ the slight inefficiency we see in the track reconstruction between 2 and 3 in phi

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mtosi (mia tosi) for CMSSW_7_4_X.

backport PR #9149

It involves the following packages:

RecoTracker/TkTrackingRegions

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @GiacomoSguazzoni, @rovere, @VinInn, @mschrode, @istaslis, @gpetruc, @cerati, @dgulhan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mtosi mtosi closed this Jul 15, 2015
@slava77
Copy link
Contributor

slava77 commented Jul 16, 2015

Mia
was this closed on purpose?

We need to move this code in later releases as well to /plugins instead of /src

@mtosi
Copy link
Contributor Author

mtosi commented Jul 16, 2015

ciao,
yes, I closed it because it was not working at the beginning,
it should be fine, now
and I'm reopening it ... I noticed that I have to fix this code in 75x and 76x as well

@mtosi mtosi reopened this Jul 16, 2015
@slava77
Copy link
Contributor

slava77 commented Jul 16, 2015

Hi Mia,

Please move the producer to the /plugins directory.

Thanks

@cmsbuild
Copy link
Contributor

Pull request #10225 was updated. @cmsbuild, @cvuosalo, @slava77 can you please check and sign again.

@mtosi
Copy link
Contributor Author

mtosi commented Jul 16, 2015

I changed yesterday, but I forgot to push !
thanks for the reminder
it should be ok, now...shouldn't it ?

@slava77
Copy link
Contributor

slava77 commented Jul 16, 2015

@cmsbuild please test

Mia, thank you.

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@mtosi
Copy link
Contributor Author

mtosi commented Jul 16, 2015

;)

On Thu, Jul 16, 2015 at 12:00 PM, Slava Krutelyov notifications@github.com
wrote:

@cmsbuild https://github.com/cmsbuild please test

Mia, thank you.


Reply to this email directly or view it on GitHub
#10225 (comment).

@slava77
Copy link
Contributor

slava77 commented Jul 19, 2015

Mia,
please update the PR subject here as well to be more descriptive (not just a pointer to a PR number)

Thanks

@slava77
Copy link
Contributor

slava77 commented Jul 19, 2015

+1

for #10225 fc8f2e1

  • code for PointSeededTrackingRegionsProducer was backported from 75X. It is not used in other places in the release at this point
  • jenkins test passed and showed no difference in comparisons with baseline as expected

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

cmsbuild added a commit that referenced this pull request Jul 21, 2015
…kingRegion

move PointSeededTrackingRegionsProducer to plugins (forward port of #10225)
@davidlange6
Copy link
Contributor

@mtosi - please change the title to describe the changes in the PR - thanks

@mtosi mtosi changed the title backport PR #9149 point seeded tracking regions (backport PR #9149) Jul 31, 2015
@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants