-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional MultiTrackValidator instances to validation #10219
Add additional MultiTrackValidator instances to validation #10219
Conversation
Then we don't need these member variables
…efCandidates back to TrackRefs
…f all tracks vs. all TPs
…standard validation sequence This is to save memory. The plots are done for all iterations in the standalone mode, where we are not as constrained with memory.
A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_7_6_X. Add additional MultiTrackValidator instances to validation It involves the following packages: CommonTools/RecoAlgos @cmsbuild, @cvuosalo, @danduggan, @deguio, @slava77 can you please review it and eventually sign? Thanks. |
@cmsbuild please test |
The tests are being triggered in jenkins. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
+1 |
Add additional MultiTrackValidator instances to validation
This PR adds three MultiTrackValidator instances to validation sequence
trackValidatorFromPV
(DQM folder "Tracking/TrackFromPV")trackValidatorFromPVAllTP
(DQM folder "Tracking/TrackFromPVAllTP")trackValidatorAllTPEffic
(DQM folder "Tracking/TrackAllTPEffic")trackValidator
efficiency is defined wrt. hard-scatter TPs)For the standard validation sequence, the new MTV instances above are set to monitor only generalTracks and highPurity tracks in order to keep the memory use under control. The instances for the "standalone mode" (running MTV privately alone), also the individual iterations are monitored.
In addition the PR includes some cleanup, most notably the recently added summary plots (#9201) are created and filled according to the
doSimTrackPlots
/doRecoTrackPlots
configuration flags.Tested in CMSSW_7_6_X_2015-07-10-1100, no changes expected in existing histograms.
@rovere @VinInn