Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional MultiTrackValidator instances to validation #10219

Merged
merged 8 commits into from
Jul 24, 2015

Conversation

makortel
Copy link
Contributor

This PR adds three MultiTrackValidator instances to validation sequence

  • trackValidatorFromPV (DQM folder "Tracking/TrackFromPV")
    • Monitors tracks associated to the reconstructed primary vertex wrt. TrackingParticles from the hard scatter event, only for events where the primary vertex is correctly identified (i.e. is matched to the generated one)
    • Track-PV association is produced with the same code as in miniAOD, the used association criteria corresponds to the "CompatibilityBTag" flag
    • Monitoring includes the full set of plots
      • Efficiency shows the fraction of hard-scatter TPs that are reconstructed and associated to PV
      • In fake rate the tracks from pileup are counted as fakes
  • trackValidatorFromPVAllTP (DQM folder "Tracking/TrackFromPVAllTP")
    • Monitors the fake rate (and similar quantities) of PV-associated tracks wrt. all TrackingParticles, i.e. shows how much of the tracks associated to PV are fakes and how much from pileup
  • trackValidatorAllTPEffic (DQM folder "Tracking/TrackAllTPEffic")
    • Monitors the efficiency of all tracks wrt. all TrackingParticles (in the existing trackValidator efficiency is defined wrt. hard-scatter TPs)
    • This quantity is not very interesting for tracking performance, but helps to check if there are differences in pileup simulation between releases (or between classical mixing and premixing)

For the standard validation sequence, the new MTV instances above are set to monitor only generalTracks and highPurity tracks in order to keep the memory use under control. The instances for the "standalone mode" (running MTV privately alone), also the individual iterations are monitored.

In addition the PR includes some cleanup, most notably the recently added summary plots (#9201) are created and filled according to the doSimTrackPlots/doRecoTrackPlots configuration flags.

Tested in CMSSW_7_6_X_2015-07-10-1100, no changes expected in existing histograms.

@rovere @VinInn

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_7_6_X.

Add additional MultiTrackValidator instances to validation

It involves the following packages:

CommonTools/RecoAlgos
Validation/RecoTrack

@cmsbuild, @cvuosalo, @danduggan, @deguio, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @ahinzmann, @abbiendi, @GiacomoSguazzoni, @jhgoh, @VinInn, @jdolen, @rovere, @wmtford, @istaslis, @cerati, @dgulhan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented Jul 19, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants