Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamic strip reco v2 #10215

Closed
wants to merge 34 commits into from
Closed

Dynamic strip reco v2 #10215

wants to merge 34 commits into from

Conversation

andrewj314
Copy link
Contributor

Rebase of DynamicStripReco_v2 branch to 7_6_X, with a goal to subsequently backport to 7_5_X.

This adds a new method for calculating tau isolation by dynamically altering strip size.

Christian and others added 30 commits May 19, 2015 11:44
- dynamic strip reconstruction for Yuta
6f399b3 
- added Loose, Medium and Tight tau ID discriminators with pileup weighted isolation
- removal of deprecated tau ID discriminators from pat::Taus
fixed typo in discriminator name
7a53594
bug-fix in storing of (raw) footprint correction
95f3fb0
- store neutral pileup weighted isolation pT sum
a90295c 
- bug-fix: disable deltaBeta corrections for pileup weighted isolation discriminators
added pileup weighted neutral isolation
b729963
fixed typo in discriminator name
b75f447
updated parameters for dynamic strip reconstruction
be2fd1b
@anehrkor
New cleaner module that works also if tau is made up of combination of
dc1625e 
pf charged hadrons and tracks -> solves rare problem with 3-prongs
having charge +/-3.
Merge pull request #9 from anehrkor/fixThreeProngCharge
7462cdc 
New charge cleaner module for taus
sutract 2 GeV from k offset values (except for 3prong0pi0), as recomm…
10bfa9d 
…ended by Yuta
Merge branch 'DynamicStripReco_v2' of github.com:cms-tau-pog/cmssw in…
55e8a57 
…to DynamicStripReco_v2
added functionality to make tau footprint correction dependent on tauPt
01212fc
tightened cut on pTouter from 0.20*tauPt to 0.10*tauPt
760321e
apply cut on ptOuter also in case of HPS combined islation 3-hit disc…
58113d5 
…riminators with deltaBeta correction
- updated deltaBeta correction factor to 0.2
cc6bf3c 
- updated thresholds for isolation WPs:
     Loose = 2.5 GeV
     Medium = 1.5 GeV
     Tight = 0.8 GeV (no change)
updates to tau vertex producers from Arun
a451d55
@andrewj314
- dynamic strip reconstruction for Yuta
e1c054f 
- added Loose, Medium and Tight tau ID discriminators with pileup weighted isolation
- removal of deprecated tau ID discriminators from pat::Taus
@andrewj314
fixed typo in discriminator name
c26646c
@andrewj314
bug-fix in storing of (raw) footprint correction
9e81b22
@andrewj314
- store neutral pileup weighted isolation pT sum
b71d423 
- bug-fix: disable deltaBeta corrections for pileup weighted isolation discriminators
@andrewj314
added pileup weighted neutral isolation
00052a2
@andrewj314
fixed typo in discriminator name
a8ebbe6
@andrewj314
updated parameters for dynamic strip reconstruction
0fbd342
@anehrkor @andrewj314
New cleaner module that works also if tau is made up of combination of
40fae23 
pf charged hadrons and tracks -> solves rare problem with 3-prongs
having charge +/-3.
@andrewj314
sutract 2 GeV from k offset values (except for 3prong0pi0), as recomm…
5ac4715 
…ended by Yuta
@andrewj314
added functionality to make tau footprint correction dependent on tauPt
48e4e2f
@andrewj314
tightened cut on pTouter from 0.20*tauPt to 0.10*tauPt
96af3ab
@andrewj314
apply cut on ptOuter also in case of HPS combined islation 3-hit disc…
7b3568d 
…riminators with deltaBeta correction
@andrewj314
- updated deltaBeta correction factor to 0.2
ff1b211 
- updated thresholds for isolation WPs:
     Loose = 2.5 GeV
     Medium = 1.5 GeV
     Tight = 0.8 GeV (no change)
@andrewj314
updates to tau vertex producers from Arun
abaac8e
@cmsbuild
Copy link
Contributor

-1

Tested at: 5fd9900
I found errors in the following unit tests:

---> test runtestTqafTopJetCombination had ERRORS
---> test runtestTqafTopKinFitter had ERRORS
---> test runtestTqafTopEventSelection had ERRORS
---> test runtestTqafTopHitFit had ERRORS
---> test runtestTqafTopEventProducers had ERRORS
---> test runtestTqafExamples had ERRORS
---> test runtestPhysicsToolsPatAlgos had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10215/7488/summary.html

@slava77
Copy link
Contributor

slava77 commented Jul 30, 2015

As discussed in the RECO meeting today, we should try to get a working version in a few days.

andrewj314 added a commit to cms-tau-pog/cmssw that referenced this pull request Aug 6, 2015
@andrewj314
New attempt to add Dynamic Strip Reco to 7_6_X - a new PR was necessa…
3a3c707 
…ry because of a rebase while debugging

Previous PR at: cms-sw#10215
@slava77
Copy link
Contributor

slava77 commented Aug 6, 2015

-1
superseded by #10605

@davidlange6 davidlange6 closed this Aug 7, 2015
slava77 pushed a commit to slava77/cmssw that referenced this pull request Aug 21, 2015
@andrewj314 @slava77devel
New attempt to add Dynamic Strip Reco to 7_6_X - a new PR was necessa…
b8b2c92 
…ry because of a rebase while debugging

Previous PR at: cms-sw#10215
andrewj314 added a commit to cms-tau-pog/cmssw that referenced this pull request Aug 24, 2015
@andrewj314
New attempt to add Dynamic Strip Reco to 7_6_X - a new PR was necessa…
7d7893b 
…ry because of a rebase while debugging

Previous PR at: cms-sw#10215
slava77 pushed a commit to slava77/cmssw that referenced this pull request Aug 24, 2015
@andrewj314 @slava77devel
New attempt to add Dynamic Strip Reco to 7_6_X - a new PR was necessa…
8508bd2 
…ry because of a rebase while debugging

Previous PR at: cms-sw#10215
andrewj314 added a commit to cms-tau-pog/cmssw that referenced this pull request Aug 25, 2015
@andrewj314
New attempt to add Dynamic Strip Reco to 7_6_X - a new PR was necessa…
332ef14 
…ry because of a rebase while debugging

Previous PR at: cms-sw#10215
slava77 pushed a commit to slava77/cmssw that referenced this pull request Aug 26, 2015
@andrewj314 @slava77devel
New attempt to add Dynamic Strip Reco to 7_6_X - a new PR was necessa…
e6e4e35 
…ry because of a rebase while debugging

Previous PR at: cms-sw#10215
@roger-wolf roger-wolf deleted the DynamicStripReco_v2 branch March 24, 2016 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
analysis-pending comparison-pending orp-pending pending-signatures reconstruction-rejected tests-rejected
Projects
None yet
Milestone
CMSSW_7_6_X
Development

Successfully merging this pull request may close these issues.
6 participants
@andrewj314 @cmsbuild @veelken @slava77 @davidlange6 @anehrkor