Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added full support for spectator variables in the TMVAEvaluator class #10204

Conversation

ferencek
Copy link
Contributor

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ferencek (Dinko Ferencek) for CMSSW_7_6_X.

Added full support for spectator variables in the TMVAEvaluator class

It involves the following packages:

CommonTools/Utils

@cmsbuild, @cvuosalo, @vadler, @monttj, @slava77 can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cvuosalo
Copy link
Contributor

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Jul 19, 2015

+1

for #10204 8275b0d

  • this extends the functionality of the TMVAEvaluator, the default behavior is unchanged
  • jenkins tests pass and comparisons with the baseline show no difference as expected

davidlange6 added a commit that referenced this pull request Jul 21, 2015
…t_from-CMSSW_7_6_X_2015-07-14-1100

Added full support for spectator variables in the TMVAEvaluator class
@davidlange6 davidlange6 merged commit 357e76f into cms-sw:CMSSW_7_6_X Jul 21, 2015
@ferencek ferencek deleted the TMVAEvaluatorSpectatorsSupport_from-CMSSW_7_6_X_2015-07-14-1100 branch July 21, 2015 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants