Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missing * in keep statement for gedGsfElectronCores #10162

Merged
merged 2 commits into from
Jul 15, 2015
Merged

missing * in keep statement for gedGsfElectronCores #10162

merged 2 commits into from
Jul 15, 2015

Conversation

shervin86
Copy link
Contributor

This bug is not present in 75X where the * is present

@cmsbuild cmsbuild added this to the Next CMSSW_7_4_X milestone Jul 13, 2015
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @shervin86 for CMSSW_7_4_X.

missing * in keep statement for gedGsfElectronCores

It involves the following packages:

Calibration/EcalAlCaRecoProducers

@cmsbuild, @mmusich, @diguida, @cerminar can you please review it and eventually sign? Thanks.
@argiro this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mmusich
Copy link
Contributor

mmusich commented Jul 13, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: 1ac9092
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10162/4561/summary.html

@cmsbuild
Copy link
Contributor

+1
Tested at: 6d93a65
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10162/8691/summary.html

@mmusich
Copy link
Contributor

mmusich commented Jul 14, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10162/8691/summary.html

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

Thanks! @shervin86 - could you also propagate this change to 75x.

davidlange6 added a commit that referenced this pull request Jul 15, 2015
@davidlange6
Merge pull request #10162 from shervin86/fixOutputAlcareco_74x
52d424a 
missing * in keep statement for gedGsfElectronCores
@davidlange6 davidlange6 merged commit 52d424a into cms-sw:CMSSW_7_4_X Jul 15, 2015
@shervin86 shervin86 deleted the fixOutputAlcareco_74x branch November 25, 2016 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
alca-approved comparison-available fully-signed orp-pending tests-approved
Projects
None yet
Milestone
Next CMSSW_7_4_X
Development

Successfully merging this pull request may close these issues.
4 participants
@shervin86 @cmsbuild @mmusich @davidlange6