Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some configuration files using nonexistent standard sequences #10116

Merged

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Jul 9, 2015

I discovered that there are a large number of python config files that cannot possibly be run because they use configuration files in Configurations/StandardSequences that were moved or removed more than three years ago, and in many cases, more than four years ago. I am working on a generator feature that requires modifying a lot of config files, so it will make life much easier if these obsolete config files that cannot possibly be used are removed from the release.
Note 1: This PR removes about 5400 lines of unusable code from the release!
Note 2: This PR should not be confused with #10030 (already merged), which removed a different set of obsolete config files.
Note 3: The original version of this PR mistakenly removed 17 additional files, that, while they did use obsolete sequences, the obsolete sequence was removed only three months ago. So this PR no longer deletes those 17 files. Thanks to Slava for catching this.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2015

A new Pull Request was created by @wmtan for CMSSW_7_6_X.

Remove some configuration files using nonexistent standard sequences

It involves the following packages:

Alignment/LaserAlignmentSimulation
Calibration/HcalAlCaRecoProducers
Calibration/HcalCalibAlgos
FastSimulation/Tracking
GeneratorInterface/AMPTInterface
GeneratorInterface/GenExtensions
GeneratorInterface/HydjetInterface
GeneratorInterface/LHEInterface
GeneratorInterface/PartonShowerVeto
GeneratorInterface/PomwigInterface
Geometry/RPCGeometry
RecoEgamma/EgammaElectronProducers
RecoJets/JetAnalyzers
RecoParticleFlow/Configuration
RecoRomanPot/RecoFP420
SLHCUpgradeSimulations/Geometry
SimCalorimetry/EcalSelectiveReadoutProducers
SimCalorimetry/HcalSimProducers
SimG4CMS/Calo
SimG4CMS/FP420
SimGeneral/DataMixingModule
SimMuon/CSCDigitizer
SimMuon/Neutron
SimTracker/SiStripDigitizer
SimTracker/TrackHistory
SimTracker/TrackerMaterialAnalysis
SimTransport/HectorProducer
Validation/HcalDigis
Validation/RecoB
Validation/RecoParticleFlow

@vciulli, @civanch, @diguida, @bendavid, @lveldere, @cvuosalo, @covarell, @ianna, @thuer, @cmsbuild, @cerminar, @Dr15Jones, @mdhildreth, @deguio, @slava77, @mmusich, @ssekmen, @danduggan can you please review it and eventually sign? Thanks.
@ghellwig, @TaiSakuma, @rappoccio, @argiro, @Martin-Grunewald, @threus, @LBeck, @mmarionncern, @imarches, @ahinzmann, @acaudron, @jlagram, @jhgoh, @lgray, @cnuttens, @prolay, @ferencek, @cerati, @Sam-Harper, @GiacomoSguazzoni, @rovere, @VinInn, @nhanvtran, @schoef, @mschrode, @dgulhan, @mkirsano, @jdolen, @makortel, @matt-komm, @mariadalfonso, @pvmulder, @cbaus, @bachtis this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented Jul 9, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2015

The tests are being triggered in jenkins.

@civanch
Copy link
Contributor

civanch commented Jul 15, 2015

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants