-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove some configuration files using nonexistent standard sequences #10116
Remove some configuration files using nonexistent standard sequences #10116
Conversation
A new Pull Request was created by @wmtan for CMSSW_7_6_X. Remove some configuration files using nonexistent standard sequences It involves the following packages: Alignment/LaserAlignmentSimulation @vciulli, @civanch, @diguida, @bendavid, @lveldere, @cvuosalo, @covarell, @ianna, @thuer, @cmsbuild, @cerminar, @Dr15Jones, @mdhildreth, @deguio, @slava77, @mmusich, @ssekmen, @danduggan can you please review it and eventually sign? Thanks. |
@cmsbuild please test |
The tests are being triggered in jenkins. |
+1 |
…iles Remove some configuration files using nonexistent standard sequences
I discovered that there are a large number of python config files that cannot possibly be run because they use configuration files in Configurations/StandardSequences that were moved or removed more than three years ago, and in many cases, more than four years ago. I am working on a generator feature that requires modifying a lot of config files, so it will make life much easier if these obsolete config files that cannot possibly be used are removed from the release.
Note 1: This PR removes about 5400 lines of unusable code from the release!
Note 2: This PR should not be confused with #10030 (already merged), which removed a different set of obsolete config files.
Note 3: The original version of this PR mistakenly removed 17 additional files, that, while they did use obsolete sequences, the obsolete sequence was removed only three months ago. So this PR no longer deletes those 17 files. Thanks to Slava for catching this.