-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bsunanda:Run2-hcx20 Update the scenarios by adding relevant xml files #10100
Conversation
A new Pull Request was created by @bsunanda for CMSSW_7_6_X. bsunanda:Run2-hcx20 Update the scenarios by adding relevant xml files It involves the following packages: Geometry/CMSCommonData @cmsbuild, @civanch, @Dr15Jones, @ianna, @mdhildreth can you please review it and eventually sign? Thanks. |
@@ -217,8 +217,6 @@ | |||
'Geometry/HcalCommonData/data/hcalouteralgo.xml', | |||
'Geometry/HcalCommonData/data/hcalforwardalgo.xml', | |||
'Geometry/HcalCommonData/data/average/hcalforwardmaterial.xml', | |||
'Geometry/HcalCommonData/data/Phase0/hcalSimNumbering.xml', | |||
'Geometry/HcalCommonData/data/Phase0/hcalRecNumbering.xml', | |||
'Geometry/MuonCommonData/data/v1/mbCommon.xml', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bsunanda - why?
@cmsbuild please test |
The tests are being triggered in jenkins. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
@@ -232,7 +236,7 @@ | |||
'Geometry/ForwardCommonData/data/totemRotations.xml', | |||
'Geometry/ForwardCommonData/data/totemt1.xml', | |||
'Geometry/ForwardCommonData/data/totemt2.xml', | |||
'Geometry/ForwardCommonData/data/ionpump.xml', | |||
'Geometry/ForwardCommonData/data/ionpump.xml')+cms.vstring( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bsunanda - why the cms.vstring() is needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The list is too long
From: David Lange [notifications@github.com]
Sent: 09 July 2015 21:37
To: cms-sw/cmssw
Cc: Sunanda Banerjee
Subject: Re: [cmssw] bsunanda:Run2-hcx20 Update the scenarios by adding relevant xml files (#10100)
In Geometry/CMSCommonData/python/Phase1_R34F16_cmsSimIdealGeometryXML_cfi.pyhttps://github.com//pull/10100#discussion_r34294339:
@@ -232,7 +236,7 @@
'Geometry/ForwardCommonData/data/totemRotations.xml',
'Geometry/ForwardCommonData/data/totemt1.xml',
'Geometry/ForwardCommonData/data/totemt2.xml',
'Geometry/ForwardCommonData/data/ionpump.xml',
'Geometry/ForwardCommonData/data/ionpump.xml')+cms.vstring(
@bsunandahttps://github.com/bsunanda - why the cms.vstring() is needed?
—
Reply to this email directly or view it on GitHubhttps://github.com//pull/10100/files#r34294339.
+1 |
bsunanda:Run2-hcx20 Update the scenarios by adding relevant xml files
Split some of the ECAL xml files to enable PhaseII definition and add files relevant for new ways of defining Hcal geometry