Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fix in HLT b-tag validation code (75X) #10052

Merged
merged 3 commits into from
Jul 9, 2015
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion HLTriggerOffline/Btag/python/HltBtagPostValidation_cff.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
#define HltBTagPostValidation for the b-tag DQM validation (efficiency and mistagrate plot)
HltBTagPostValidation = cms.EDAnalyzer("HLTBTagHarvestingAnalyzer",
HLTPathNames = cms.vstring(
'HLT_PFMET120_NoiseCleaned_BTagCSV07_v',
'HLT_PFMET120_NoiseCleaned_BTagCSV0p72_v',
'HLT_CaloMHTNoPU90_PFMET90_PFMHT90_IDTight_',
'HLT_QuadPFJet_VBF',
'HLT_Ele32_eta2p1_',
Expand Down
10 changes: 5 additions & 5 deletions HLTriggerOffline/Btag/python/HltBtagValidation_cff.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
#denominator trigger
hltBtagTriggerSelection = cms.EDFilter( "TriggerResultsFilter",
triggerConditions = cms.vstring(
"HLT_PFMET120_NoiseCleaned_BTagCSV07_* OR HLT_CaloMHTNoPU90_PFMET90_PFMHT90_IDTight_* OR HLT_QuadPFJet_VBF* OR HLT_Ele32_eta2p1_* OR HLT_IsoMu24_eta2p1_*"),
"HLT_PFMET120_NoiseCleaned_BTagCSV0p72_* OR HLT_CaloMHTNoPU90_PFMET90_PFMHT90_IDTight_* OR HLT_QuadPFJet_VBF* OR HLT_Ele32_eta2p1_* OR HLT_IsoMu24_eta2p1_*"),
hltResults = cms.InputTag( "TriggerResults", "", "HLT" ),
# l1tResults = cms.InputTag( "simGtDigis" ),
l1tResults = cms.InputTag( "gtDigis" ),
Expand All @@ -19,9 +19,9 @@
SimVertexCollection = cms.InputTag("g4SimHits"),
TriggerResults = cms.InputTag('TriggerResults','',"HLT"),
HLTPathNames =cms.vstring(
'HLT_PFMET120_NoiseCleaned_BTagCSV07_v',
'HLT_PFMET120_NoiseCleaned_BTagCSV07_v',
'HLT_PFMET120_NoiseCleaned_BTagCSV07_v',
'HLT_PFMET120_NoiseCleaned_BTagCSV0p72_v',
'HLT_PFMET120_NoiseCleaned_BTagCSV0p72_v',
'HLT_PFMET120_NoiseCleaned_BTagCSV0p72_v',
'HLT_CaloMHTNoPU90_PFMET90_PFMHT90_IDTight_',
'HLT_CaloMHTNoPU90_PFMET90_PFMHT90_IDTight_',
'HLT_CaloMHTNoPU90_PFMET90_PFMHT90_IDTight_',
Expand All @@ -43,7 +43,7 @@
hltbTagValidation = cms.EDAnalyzer("HLTBTagPerformanceAnalyzer",
TriggerResults = cms.InputTag('TriggerResults','','HLT'),
HLTPathNames =cms.vstring(
'HLT_PFMET120_NoiseCleaned_BTagCSV07_v',
'HLT_PFMET120_NoiseCleaned_BTagCSV0p72_v',
'HLT_CaloMHTNoPU90_PFMET90_PFMHT90_IDTight_',
'HLT_QuadPFJet_VBF',
'HLT_Ele32_eta2p1_',
Expand Down
4 changes: 3 additions & 1 deletion HLTriggerOffline/Btag/src/HLTBTagHarvestingAnalyzer.cc
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,9 @@ void HLTBTagHarvestingAnalyzer::mistagrate(DQMStore::IBooker& ibooker, DQMStore:
eff->SetBinContent(binX,miseff);
eff->SetBinError(binX,miseffErr);
}
ibooker.book1D(effName.c_str(),eff);
MonitorElement *me;
me = ibooker.book1D(effName.c_str(),eff);
me->setEfficiencyFlag();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this need to be deleted?


delete eff;
return;
Expand Down
13 changes: 6 additions & 7 deletions HLTriggerOffline/Btag/test/config.ini
Original file line number Diff line number Diff line change
@@ -1,19 +1,18 @@
[config]
maxevents=10000
maxevents=-1
;denominatorTriggerPath=HLT_PFMET170*
processname=HLT
hltjets=ak4GenJetsNoNu
cmsswver= CMSSW_X_Y_Z
files=
root://xrootd.ba.infn.it///store/relval/CMSSW_7_5_0_pre2/RelValTTbar_13/GEN-SIM-DIGI-RAW-HLTDEBUG/MCRUN2_74_V7-v1/00000/3472D399-B3E3-E411-8CF5-003048FFD76E.root
; file:RelVal750pre3.root
root://xrootd.ba.infn.it///store/relval/CMSSW_7_5_0_pre6/RelValTTbar_13/GEN-SIM-DIGI-RAW-HLTDEBUG/PU25ns_75X_mcRun2_asymptotic_v1-v1/00000/00DE8AFD-1D1C-E511-988E-0025905A612C.root

;Paths names and btag variables that you want to monitor
[btag]
HLT_PFMET120_NoiseCleaned_BTagCSV07_v:
HLT_PFMET120_NoiseCleaned_BTagCSV0p72_v:
hltCombinedSecondaryVertexBJetTagsCalo

HLT_CaloMHTNoPU90_PFMET90_PFMHT90_IDLoose_:
HLT_CaloMHTNoPU90_PFMET90_PFMHT90_IDTight_:
hltCombinedSecondaryVertexBJetTagsCalo

HLT_QuadPFJet_VBF:
Expand All @@ -28,12 +27,12 @@ HLT_IsoMu24_eta2p1_:
;Paths names and vertex variables that you want to monitor
[vertex]

HLT_PFMET120_NoiseCleaned_BTagCSV07_v:
HLT_PFMET120_NoiseCleaned_BTagCSV0p72_v:
hltFastPrimaryVertex
hltFastPVPixelVertices
hltVerticesL3

HLT_CaloMHTNoPU90_PFMET90_PFMHT90_IDLoose_:
HLT_CaloMHTNoPU90_PFMET90_PFMHT90_IDTight_:
hltFastPrimaryVertex
hltFastPVPixelVertices
hltVerticesL3
Expand Down
2 changes: 1 addition & 1 deletion HLTriggerOffline/Btag/test/testSequences.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@


process.source = cms.Source("PoolSource",
fileNames = cms.untracked.vstring("root://xrootd.ba.infn.it///store/relval/CMSSW_7_5_0_pre2/RelValTTbar_13/GEN-SIM-DIGI-RAW-HLTDEBUG/MCRUN2_74_V7-v1/00000/3472D399-B3E3-E411-8CF5-003048FFD76E.root")
fileNames = cms.untracked.vstring("root://xrootd.ba.infn.it///store/relval/CMSSW_7_5_0_pre6/RelValTTbar_13/GEN-SIM-DIGI-RAW-HLTDEBUG/PU25ns_75X_mcRun2_asymptotic_v1-v1/00000/00DE8AFD-1D1C-E511-988E-0025905A612C.root")
# fileNames = cms.untracked.vstring("file:RelVal750pre3.root")
)

Expand Down