-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removal of redundant (generic) QIE shape and its usage #10042
Removal of redundant (generic) QIE shape and its usage #10042
Conversation
A new Pull Request was created by @abdoulline for CMSSW_7_6_X. Removal of redundant (generic) QIE shape and it's usage It involves the following packages: CalibFormats/HcalObjects @cmsbuild, @mmusich, @diguida, @cerminar can you please review it and eventually sign? Thanks. |
please test |
The tests are being triggered in jenkins. |
Looks like the test needs to be re-started ? |
@Degano can you please restart the tests? |
tests restarted in jenkins but will take a while to finish as many of the build resources are being used to build 11h00 IBs |
+1
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
+1 |
…lCoder_76X Removal of redundant (generic) QIE shape and its usage
HCAL QIE shape is described by HcalQieShape
CondFormats/HcalObjects/interface/HcalQIEShape.h
Removed stuff : QieShape + HcalChannelCoder