-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve exception message and comments only #10026
Conversation
This is motivated by a user question from the hypernews. We changed the AssociationMap interface in 7_5_X in a way that requires a change to user code. The exception message given when the user has not changed their code needed improvement. I also improved the comments. The changes in this PR should not change the behavior of cmsRun unless an exception is thrown.
A new Pull Request was created by @wddgit (W. David Dagenhart) for CMSSW_7_5_X. Improve exception message and comments only It involves the following packages: DataFormats/Common @cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks. |
please test |
+1 |
The tests are being triggered in jenkins. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
+1 |
Improve exception message and comments only
This is motivated by a user question from the hypernews.
We changed the AssociationMap interface in 7_5_X in a
way that requires a change to user code. The exception
message given when the user has not changed their code
needed improvement. I also improved the comments. The
changes in this PR should not change the behavior of
cmsRun unless an exception is thrown.