-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use C++ regex, not boost regex, in the framework where feasible. #10000
Conversation
A new Pull Request was created by @wmtan for CMSSW_7_6_X. Use C++ regex, not boost regex, in the framework where feasible. It involves the following packages: FWCore/Catalog @cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks. |
please test |
The tests are being triggered in jenkins. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
+1 |
Use C++ regex, not boost regex, in the framework where feasible.
std::regex is supported in gcc491, so we can use it instead of boost::regex in many cases.
boost::regex is used in the framework in six different places. This PR replaces the use of boost::regex with std::regex in those four places in the framework where the replacement is trivial and obvious.
In the other two cases, boost::regex use is left alone because boost functions are used that have no obvious equivalent in the C++ standard library.