Do we still need to support the muon reco duplicate mitigation in PhysicsTools/PatUtils?

[perrotta]

While reviewing PR #33307 it was evident that we keep spending time and effort in maintaining some code which is quite likely not needed any more in CMSSW:

• PhysicsTools/PatUtils/python/tools/muonRecoMitigation.py assumes the existence of a PFCandPtrProjector plugin, which is not found anywhere in CMSSW, not even in 9_1_X (which is the release where this config was introduced with Port of the last 80X/90X MET (#16174 #17524) changes in 91X #18165)
• That muon reco duplicate mitigation is only required by corMETFromMuonAndEG, which is defined in PhysicsTools/​PatUtils/​python/​tools/​corMETFromMuonAndEG.py and only called by PhysicsTools/PatAlgos/python/slimming/extraSlimmedMETs_MuEGFixMoriond2017.py,;which according to the name is quite likely not in use any more
• Moreover, muCorrection=False in there, and therefore this muonRecoMitigation wasn't actually ever accessed even from there.

The main point is the following: do we still need to support the muon reco duplicate mitigation in corMETFromMuonAndEG? Do we need to keep supporting corMETFromMuonAndEG at all? Couldn't they be safely removed from the release?

@zdemirag @kirschen @lathomas @ahinzmann @mariadalfonso

[cmsbuild]

A new Issue was created by @perrotta .

@Dr15Jones, @dpiparo, @silviodonato, @smuzaffar, @makortel, @qliphy can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

[perrotta]

assign xpog, reconstruction

[cmsbuild]

New categories assigned: reconstruction,xpog

@slava77,@fgolf,@mariadalfonso,@perrotta,@jpata,@gouskos you have been requested to review this Pull request/Issue and eventually sign? Thanks

[jpata]

bringing this up with @michaelwassmer, the current MET reco contact.

[jpata]

type jetmet

[michaelwassmer]

To my best knowledge, this isn't used anymore. Also, the corresponding MET filters https://github.com/cms-sw/cmssw/blob/master/RecoMET/METFilters/python/badGlobalMuonTaggersAOD_cff.py and https://github.com/cms-sw/cmssw/blob/master/RecoMET/METFilters/python/badGlobalMuonTaggersMiniAOD_cff.py seem not to be recommended anymore, see https://twiki.cern.ch/twiki/bin/viewauth/CMS/MissingETOptionalFiltersRun2.

[jpata]

Right, these can't be used because they are relying on old, removed code. Likely the best solution would be to remove these modules.

[vlimant]

IMO it was a mistake to let go of #33307 without enforcing the cleanup. Now the cost of tracking this issue on a cold iron is larger.
@michaelwassmer : is this something that was followed up on with a PR ?

[michaelwassmer]

@vlimant
I'm not sure I understand what the issue is. Could you explain?

[vlimant]

I don't know much more than what the PR description says #33406 (comment)
looks like there are some python configuration files configuring modules that do not exist anymore ?

[vlimant]

there is essentially some cleanup to be done from within https://github.com/cms-sw/cmssw/blob/master/PhysicsTools/PatUtils/python/tools/corMETFromMuonAndEG.py to ever have the chance at calling PFCandPtrProjector which does not exists.

Is that something you could make a 13.0 PR for @michaelwassmer ? it might be a good occasion to review and streamline what this functions are doing. that looks very unnaturally complicated to me

[michaelwassmer]

So should we just remove this stuff? As far as I understood the discussion above, these things aren't used anymore, right?

[vlimant]

yes

[michaelwassmer]

Ok, I'll try to get this done today or tomorrow.
Edit: Done, see #40591 .

[perrotta]

+1

• Fixed by removed old and unused configs linked to reco muon duplicate mitigation #40591, thank you @michaelwassmer