Merge pull request #46718 from smuzaffar/ubsan-l1-fix-TrackFindingTra…

…cklet [UBSAN][L1]Properly initialize data members
cms-sw · Nov 19, 2024 · f472813 · f472813
2 parents 3685722 + 34a2c7b
commit f472813
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 8 deletions.
diff --git a/L1Trigger/TrackFindingTracklet/src/MatchEngineUnit.cc b/L1Trigger/TrackFindingTracklet/src/MatchEngineUnit.cc
@@ -9,15 +9,22 @@ MatchEngineUnit::MatchEngineUnit(const Settings& settings,
                                  bool barrel,
                                  unsigned int layerdisk,
                                  const TrackletLUT& luttable)
-    : settings_(settings), luttable_(luttable), candmatches_(3) {
-  idle_ = true;
-  print_ = false;
+    : settings_(settings),
+      isPSseed_(false),
+      idle_(true),
+      almostfullsave_(false),
+      luttable_(luttable),
+      isPSseed__(false),
+      isPSseed___(false),
+      isPSseed____(false),
+      good__(false),
+      good___(false),
+      good____(false),
+      candmatches_(3),
+      print_(false) {
   imeu_ = -1;
   barrel_ = barrel;
   layerdisk_ = layerdisk;
-  good__ = false;
-  good___ = false;
-  good____ = false;
   ir2smin_ = 0;
   if (layerdisk_ >= N_LAYER) {
     double rmin2s = (layerdisk_ < N_LAYER + 2) ? settings_.rDSSinner(0) : settings_.rDSSouter(0);

diff --git a/L1Trigger/TrackFindingTracklet/src/TrackletEngineUnit.cc b/L1Trigger/TrackFindingTracklet/src/TrackletEngineUnit.cc
@@ -15,8 +15,14 @@ TrackletEngineUnit::TrackletEngineUnit(const Settings* const settings,
                                        const TrackletLUT* pttableinnernew,
                                        const TrackletLUT* pttableouternew,
                                        VMStubsTEMemory* outervmstubs)
-    : settings_(settings), pttableinnernew_(pttableinnernew), pttableouternew_(pttableouternew), candpairs_(3) {
-  idle_ = true;
+    : settings_(settings),
+      nearfull_(false),
+      idle_(true),
+      pttableinnernew_(pttableinnernew),
+      pttableouternew_(pttableouternew),
+      goodpair_(false),
+      goodpair__(false),
+      candpairs_(3) {
   nbitsfinephi_ = nbitsfinephi;
   layerdisk2_ = layerdisk2;
   layerdisk1_ = layerdisk1;