Skip to content

Commit

Permalink
Code check
Browse files Browse the repository at this point in the history
  • Loading branch information
Sunanda committed Mar 24, 2023
1 parent 02ee2a2 commit f224b45
Show file tree
Hide file tree
Showing 7 changed files with 16 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
class EcalBarrelHardcodedTopology final : public CaloSubdetectorTopology {
public:
/// create a new Topology
EcalBarrelHardcodedTopology() {};
EcalBarrelHardcodedTopology(){};

~EcalBarrelHardcodedTopology() override = default;

Expand Down
3 changes: 2 additions & 1 deletion Geometry/CaloTopology/src/EcalTrigTowerConstituentsMap.cc
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,8 @@ EcalTrigTowerDetId EcalTrigTowerConstituentsMap::towerOf(const DetId& id) const
//..........from file and done only for 1 quadrant
//move from quadrant 1 to the actual one:
// phiTower = changeTowerQuadrant(phiTower, 1, originalId.iquadrant());
edm::LogVerbatim("EcalTrigTowerConstituentsMap") << "EcalTrigTowerConstituentsMap " << originalId.zside() << " " << etaTower << " " << phiTower;
edm::LogVerbatim("EcalTrigTowerConstituentsMap")
<< "EcalTrigTowerConstituentsMap " << originalId.zside() << " " << etaTower << " " << phiTower;
return EcalTrigTowerDetId(originalId.zside(), EcalEndcap, etaTower, phiTower);
}
}
Expand Down
2 changes: 1 addition & 1 deletion Geometry/CommonTopologies/src/RectangularStripTopology.cc
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ RectangularStripTopology::RectangularStripTopology(int ns, float p, float l)

#ifdef VERBOSE
edm::LogVerbatim("CommonTopologies") << "Constructing RectangularStripTopology with"
<< " nstrips = " << ns << " pitch = " << p << " length = " << l;
<< " nstrips = " << ns << " pitch = " << p << " length = " << l;
#endif
}

Expand Down
3 changes: 2 additions & 1 deletion Geometry/CommonTopologies/src/TkRadialStripTopology.cc
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@ namespace {
struct Stat {
Stat(const char* in) : name(in){};
~Stat() {
edm::LogVerbatim("CommonTopologies") << name << ": atan0 calls tot/large/over1: " << natan << "/" << nlarge << "/" << over1;
edm::LogVerbatim("CommonTopologies")
<< name << ": atan0 calls tot/large/over1: " << natan << "/" << nlarge << "/" << over1;
}

void add(float t) {
Expand Down
7 changes: 5 additions & 2 deletions Geometry/CommonTopologies/src/TrapezoidalStripTopology.cc
Original file line number Diff line number Diff line change
Expand Up @@ -12,15 +12,18 @@ TrapezoidalStripTopology::TrapezoidalStripTopology(int ns, float p, float l, flo
theOffset = -theNumberOfStrips / 2. * thePitch;
theYAxOr = 1;
#ifdef EDM_ML_DEBUG
edm::LogVerbatim("CommonTopologies") << "Constructing TrapezoidalStripTopology with nstrips = " << ns << " pitch = " << p << " length = " << l << " r0 =" << r0;
edm::LogVerbatim("CommonTopologies") << "Constructing TrapezoidalStripTopology with nstrips = " << ns
<< " pitch = " << p << " length = " << l << " r0 =" << r0;
#endif
}

TrapezoidalStripTopology::TrapezoidalStripTopology(int ns, float p, float l, float r0, int yAx)
: theNumberOfStrips(ns), thePitch(p), theDistToBeam(r0), theDetHeight(l), theYAxOr(yAx) {
theOffset = -theNumberOfStrips / 2. * thePitch;
#ifdef EDM_ML_DEBUG
edm::LogVerbatim("CommonTopologies") << "Constructing TrapezoidalStripTopology with nstrips = " << ns << " pitch = " << p << " length = " << l << " r0 =" << r0 << " yAxOrientation =" << yAx;
edm::LogVerbatim("CommonTopologies") << "Constructing TrapezoidalStripTopology with nstrips = " << ns
<< " pitch = " << p << " length = " << l << " r0 =" << r0
<< " yAxOrientation =" << yAx;
#endif
}

Expand Down
4 changes: 3 additions & 1 deletion Geometry/CommonTopologies/test/ValidateRadial.cc
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,9 @@ bool ValidateRadial::pass_frame_change_test(const TkRadialStripTopology* t,
const bool passe = (secondOrder ? pass2e : pass1e);

if (printOut_ && ((!passp) || ((!posOnly_) && (!passe))))
edm::LogVerbatim("CommonTopologies") << "FAILED " << "(" << strip << ", " << newstrip << ", " << mp.x() << ")\t" << "(" << stripErr2 << ", " << me.uu() << ")\t\t" << (me.uv());
edm::LogVerbatim("CommonTopologies") << "FAILED "
<< "(" << strip << ", " << newstrip << ", " << mp.x() << ")\t"
<< "(" << stripErr2 << ", " << me.uu() << ")\t\t" << (me.uv());
return passp & passe;
}

Expand Down
3 changes: 2 additions & 1 deletion Geometry/CommonTopologies/test/testDetSort.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,8 @@ class MyDet : public GeomDet {
// A simple helper for printing the object
struct dump {
void operator()(const GeomDet& o) {
edm::LogVerbatim("CommonTopologies") << o.position() << " R : " << o.position().perp() << " Phi: " << o.position().phi() << " Z : " << o.position().z();
edm::LogVerbatim("CommonTopologies") << o.position() << " R : " << o.position().perp()
<< " Phi: " << o.position().phi() << " Z : " << o.position().z();
}
void operator()(const GeomDet* o) { operator()(*o); }
};
Expand Down

0 comments on commit f224b45

Please sign in to comment.