Skip to content

Commit

Permalink
Avoid compilation warnings in some of the codes of Validation/RecoTau
Browse files Browse the repository at this point in the history
  • Loading branch information
Sunanda committed Dec 28, 2021
1 parent 182d129 commit ac80bd8
Show file tree
Hide file tree
Showing 7 changed files with 11 additions and 11 deletions.
1 change: 0 additions & 1 deletion Validation/RecoTau/interface/TauTagValidation.h
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
// user include files

#include "FWCore/Common/interface/Provenance.h"
#include "FWCore/Framework/interface/EDAnalyzer.h"
#include "FWCore/Framework/interface/Event.h"
#include "FWCore/Framework/interface/MakerMacros.h"
#include "FWCore/ParameterSet/interface/ParameterSet.h"
Expand Down
1 change: 0 additions & 1 deletion Validation/RecoTau/interface/TauValidationMiniAOD.h
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
// Original Author: Aniello Spiezia On August 13, 2019
// user include files

#include "FWCore/Framework/interface/EDAnalyzer.h"
#include "FWCore/Framework/interface/Event.h"
#include "FWCore/Framework/interface/MakerMacros.h"
#include "FWCore/ParameterSet/interface/ParameterSet.h"
Expand Down
5 changes: 3 additions & 2 deletions Validation/RecoTau/plugins/DQMFileLoader.h
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
*/

// framework & common header files
#include "FWCore/Framework/interface/EDAnalyzer.h"
#include "FWCore/Framework/interface/one/EDAnalyzer.h"
#include "FWCore/Framework/interface/Event.h"
#include "FWCore/Framework/interface/EventSetup.h"
#include "FWCore/ParameterSet/interface/ParameterSet.h"
Expand All @@ -21,7 +21,7 @@
#include <vector>
#include <string>

class TauDQMFileLoader : public edm::EDAnalyzer {
class TauDQMFileLoader : public edm::one::EDAnalyzer<edm::one::WatchRuns> {
typedef dqm::legacy::DQMStore DQMStore;
typedef dqm::legacy::MonitorElement MonitorElement;

Expand All @@ -42,6 +42,7 @@ class TauDQMFileLoader : public edm::EDAnalyzer {
~TauDQMFileLoader() override;
void analyze(const edm::Event&, const edm::EventSetup&) override;
void endJob() override {}
void beginRun(edm::Run const&, edm::EventSetup const&) override {}
void endRun(const edm::Run& r, const edm::EventSetup& c) override;

private:
Expand Down
1 change: 0 additions & 1 deletion Validation/RecoTau/plugins/DQMHistEffProducer.h
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
*/

// framework & common header files
#include "FWCore/Framework/interface/EDAnalyzer.h"
#include "FWCore/Framework/interface/Event.h"
#include "FWCore/Framework/interface/EventSetup.h"
#include "FWCore/ParameterSet/interface/ParameterSet.h"
Expand Down
5 changes: 3 additions & 2 deletions Validation/RecoTau/plugins/DQMHistNormalizer.cc
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
*/

// framework & common header files
#include "FWCore/Framework/interface/EDAnalyzer.h"
#include "FWCore/Framework/interface/one/EDAnalyzer.h"
#include "FWCore/Framework/interface/Event.h"
#include "FWCore/Framework/interface/EventSetup.h"
#include "FWCore/Framework/interface/MakerMacros.h"
Expand All @@ -27,14 +27,15 @@

using namespace std;

class DQMHistNormalizer : public edm::EDAnalyzer {
class DQMHistNormalizer : public edm::one::EDAnalyzer<edm::one::WatchRuns> {
public:
typedef dqm::legacy::DQMStore DQMStore;
typedef dqm::legacy::MonitorElement MonitorElement;

explicit DQMHistNormalizer(const edm::ParameterSet&);
~DQMHistNormalizer() override;
void analyze(const edm::Event&, const edm::EventSetup&) override;
void beginRun(const edm::Run&, const edm::EventSetup&) override {}
void endRun(const edm::Run& r, const edm::EventSetup& c) override;

private:
Expand Down
5 changes: 3 additions & 2 deletions Validation/RecoTau/plugins/DQMHistPlotter.h
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
*/

// framework & common header files
#include "FWCore/Framework/interface/EDAnalyzer.h"
#include "FWCore/Framework/interface/one/EDAnalyzer.h"
#include "FWCore/Framework/interface/Event.h"
#include "FWCore/Framework/interface/EventSetup.h"
#include "FWCore/ParameterSet/interface/ParameterSet.h"
Expand All @@ -24,7 +24,7 @@
#include <vector>
#include <map>

class TauDQMHistPlotter : public edm::EDAnalyzer {
class TauDQMHistPlotter : public edm::one::EDAnalyzer<edm::one::WatchRuns> {
typedef dqm::legacy::DQMStore DQMStore;
typedef dqm::legacy::MonitorElement MonitorElement;

Expand Down Expand Up @@ -157,6 +157,7 @@ class TauDQMHistPlotter : public edm::EDAnalyzer {
explicit TauDQMHistPlotter(const edm::ParameterSet&);
~TauDQMHistPlotter() override;
void analyze(const edm::Event&, const edm::EventSetup&) override;
void beginRun(edm::Run const&, edm::EventSetup const&) override {}
void endRun(const edm::Run& r, const edm::EventSetup& c) override;

private:
Expand Down
4 changes: 2 additions & 2 deletions Validation/RecoTau/plugins/DQMSimpleFileSaver.h
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
*/

// framework & common header files
#include "FWCore/Framework/interface/EDAnalyzer.h"
#include "FWCore/Framework/interface/one/EDAnalyzer.h"
#include "FWCore/Framework/interface/Event.h"
#include "FWCore/Framework/interface/EventSetup.h"
#include "FWCore/ParameterSet/interface/ParameterSet.h"
Expand All @@ -19,7 +19,7 @@

#include <string>

class TauDQMSimpleFileSaver : public edm::EDAnalyzer {
class TauDQMSimpleFileSaver : public edm::one::EDAnalyzer<> {
public:
typedef dqm::legacy::DQMStore DQMStore;
typedef dqm::legacy::MonitorElement MonitorElement;
Expand Down

0 comments on commit ac80bd8

Please sign in to comment.