Update per PR feedback, largely comment removal + GT fixes

cms-sw · Oct 22, 2024 · ab400b6 · ab400b6
1 parent 6200a84
commit ab400b6
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 15 deletions.
diff --git a/DQM/HcalTasks/interface/ZDCQIE10Task.h b/DQM/HcalTasks/interface/ZDCQIE10Task.h
@@ -48,9 +48,6 @@ class ZDCQIE10Task : public hcaldqm::DQTask {
   ~ZDCQIE10Task() override {}
 
   void bookHistograms(DQMStore::IBooker &, edm::Run const &, edm::EventSetup const &) override;
-  //    std::shared_ptr<hcaldqm::Cache> globalBeginLuminosityBlock(edm::LuminosityBlock const &,
-  //							       edm::EventSetup const &) const override;
-  //void globalEndLuminosityBlock(edm::LuminosityBlock const &, edm::EventSetup const &) override;
 
 protected:
   void _process(edm::Event const &, edm::EventSetup const &) override;
@@ -63,7 +60,6 @@ class ZDCQIE10Task : public hcaldqm::DQTask {
   edm::EDGetToken sumToken_;
   edm::ESGetToken<HcalTopology, HcalRecNumberingRecord> htopoToken_;
   edm::ESGetToken<HcalLongRecoParams, HcalLongRecoParamsRcd> paramsToken_;
-  //edm::EDGetTokenT<l1t::EtSumBxCollection> sumZDCToken_;
 
   //emap
   hcaldqm::electronicsmap::ElectronicsMap _ehashmap;  // online only

diff --git a/DQM/HcalTasks/plugins/ZDCQIE10Task.cc b/DQM/HcalTasks/plugins/ZDCQIE10Task.cc
@@ -11,12 +11,8 @@ ZDCQIE10Task::ZDCQIE10Task(edm::ParameterSet const& ps)
   _tagQIE10 = ps.getUntrackedParameter<edm::InputTag>("tagQIE10", edm::InputTag("hcalDigis", "ZDC"));
   _tokQIE10 = consumes<QIE10DigiCollection>(_tagQIE10);
 
-  //const edm::EDGetTokenT<l1t::EtSumBxCollection> sumZDCToken_;
-
   sumTag = ps.getUntrackedParameter<edm::InputTag>("etSumTag", edm::InputTag("etSumZdcProducer", ""));
-  //sumTag = ps.getParameter<edm::InputTag>("etSumTag");
   sumToken_ = consumes<l1t::EtSumBxCollection>(sumTag);
-  //sumZDCToken_ = consumes<l1t::EtSumBxCollection>(ps.getUntrackedParameter<edm::InputTag>("sumZDCToken"));
 
   htopoToken_ = esConsumes<HcalTopology, HcalRecNumberingRecord>();
   paramsToken_ = esConsumes<HcalLongRecoParams, HcalLongRecoParamsRcd>();

diff --git a/DQM/Integration/python/clients/hcal_dqm_sourceclient-live_cfg.py b/DQM/Integration/python/clients/hcal_dqm_sourceclient-live_cfg.py
@@ -33,7 +33,7 @@
 from DQM.Integration.config.online_customizations_cfi import *
 if useOfflineGT:
         process.load("Configuration.StandardSequences.FrontierConditions_GlobalTag_cff")
-        process.GlobalTag.globaltag = '141X_dataRun3_Prompt_Candidate_2024_10_08_09_42_50'
+        process.GlobalTag.globaltag = autoCond['run3_data_prompt']
 else:
 	process.load('DQM.Integration.config.FrontierCondition_GT_cfi')
 
@@ -59,11 +59,11 @@
 process = customise(process)
 process.DQMStore.verbose = 0
 
-'''
+
 if not unitTest and not useFileInput :
   if not options.BeamSplashRun :
     process.source.minEventsPerLumi = 100
-'''
+
 #-------------------------------------
 #	CMSSW/Hcal non-DQM Related Module import
 #-------------------------------------
@@ -254,10 +254,6 @@
 )
 process.options.wantSummary = True
 
-process.maxEvents = cms.untracked.PSet(
-    input = cms.untracked.int32(-1)
-    )
-
 # tracer
 #process.Tracer = cms.Service("Tracer")
 print("Final Source settings:", process.source)