Skip to content

Commit

Permalink
Merge pull request #9424 from cms-sw/revert-9423-revert-9080-p5-addons
Browse files Browse the repository at this point in the history
Revert "Revert "74x: Additional features needed for P5 visualization""
  • Loading branch information
davidlange6 committed Jun 3, 2015
2 parents 0e174d2 + d798b29 commit ab1a44b
Show file tree
Hide file tree
Showing 39 changed files with 818 additions and 354 deletions.
9 changes: 7 additions & 2 deletions Fireworks/Calo/plugins/FWCaloRecHitDigitSetProxyBuilder.cc
Original file line number Diff line number Diff line change
Expand Up @@ -11,20 +11,24 @@
#include "Fireworks/Core/interface/FWProxyBuilderConfiguration.h"

FWCaloRecHitDigitSetProxyBuilder::FWCaloRecHitDigitSetProxyBuilder()
: m_invertBox(false), m_ignoreGeoShapeSize(false)
: m_invertBox(false), m_ignoreGeoShapeSize(false), m_enlarge(1.0)
{}

//______________________________________________________________________________

void FWCaloRecHitDigitSetProxyBuilder::setItem(const FWEventItem* iItem)
{
FWProxyBuilderBase::setItem(iItem);
// if (iItem) iItem->getConfig()->assertParam( "IgnoreShapeSize", false);
if (iItem) {
iItem->getConfig()->assertParam( "Enlarge", 1.0, 1.0, 5.0);
// iItem->getConfig()->assertParam( "IgnoreShapeSize", false);
}
}
//______________________________________________________________________________

void FWCaloRecHitDigitSetProxyBuilder::viewContextBoxScale( const float* corners, float scale, bool plotEt, std::vector<float>& scaledCorners, const CaloRecHit*)
{
scale *= m_enlarge;
if ( m_ignoreGeoShapeSize)
{
// Same functionality as fireworks::energyTower3DCorners()
Expand Down Expand Up @@ -141,6 +145,7 @@ FWCaloRecHitDigitSetProxyBuilder::build( const FWEventItem* iItem, TEveElementLi
if (!size) return;

// m_ignoreGeoShapeSize = item()->getConfig()->value<bool>("IgnoreShapeSize");
m_enlarge = item()->getConfig()->value<double>("Enlarge");

std::vector<float> scaledCorners(24);

Expand Down
1 change: 1 addition & 0 deletions Fireworks/Calo/plugins/FWCaloRecHitDigitSetProxyBuilder.h
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ class FWCaloRecHitDigitSetProxyBuilder : public FWDigitSetProxyBuilder

bool m_invertBox;
bool m_ignoreGeoShapeSize;
double m_enlarge;
TEveVector m_vector; // internal memeber, to avoid constant recreation
};
#endif
1 change: 0 additions & 1 deletion Fireworks/Core/doc/Core.doc
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,6 @@
- FWHFView
- FWHLTTriggerTableView
- FWHLTValidator
- FWHandle
- FWISpyView
- FWIntValueListener
- FWIntValueListenerBase
Expand Down
5 changes: 5 additions & 0 deletions Fireworks/Core/interface/ActionsList.h
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,11 @@ namespace cmsshow {
extern const std::string sLoadConfig;
extern const std::string sSaveConfig;
extern const std::string sSaveConfigAs;

extern const std::string sLoadPartialConfig;
extern const std::string sSavePartialConfig;
extern const std::string sSavePartialConfigAs;

extern const std::string sExportImage;
extern const std::string sExportAllImages;

Expand Down
8 changes: 6 additions & 2 deletions Fireworks/Core/interface/CmsShowMainBase.h
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,10 @@ class CmsShowMainBase

void writeToConfigFile(const std::string &config);
void writeToCurrentConfigFile();
void writePartialToConfigFile();
void reloadConfiguration(const std::string &config);
void partialWriteToConfigFile(const std::string &config);
void partialLoadConfiguration(const std::string &config);
void setupConfiguration();

void registerPhysicsObject(const FWPhysicsObjectDesc&iItem);
Expand Down Expand Up @@ -114,8 +117,9 @@ class CmsShowMainBase
void playForward();
void playBackward();
bool isPlaying() const { return m_isPlaying; }
void setIsPlaying(bool value) { m_isPlaying = value; }
virtual void stopPlaying() = 0;

virtual void checkKeyBindingsOnPLayEventsStateChanged() {}
virtual void stopPlaying();
virtual void autoLoadNewEvent() = 0;

void setPlayLoop();
Expand Down
2 changes: 1 addition & 1 deletion Fireworks/Core/interface/FW3DView.h
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#ifndef Fireworks_Core_FW3DEnergyView_h
#ifndef Fireworks_Core_FW3DView_h
#define Fireworks_Core_FW3DView_h
// -*- C++ -*-
//
Expand Down
5 changes: 5 additions & 0 deletions Fireworks/Core/interface/FW3DViewBase.h
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ class FW3DViewGeometry;
class FWColorManager;
class TGLClip;
class TEveLine;
class TEveBoxSet;

class FW3DViewDistanceMeasureTool;

Expand Down Expand Up @@ -61,6 +62,7 @@ class FW3DViewBase : public FWEveView
virtual bool requestGLHandlerPick() const;
void setCurrentDMTVertex(double x, double y, double z);

void showEcalBarrel(bool);
private:
FW3DViewBase(const FW3DViewBase&); // stop default

Expand All @@ -78,6 +80,9 @@ class FW3DViewBase : public FWEveView
FWBoolParameter m_showTrackerBarrel;
FWBoolParameter m_showTrackerEndcap;

TEveBoxSet* m_ecalBarrel;
FWBoolParameter m_showEcalBarrel;

FWEnumParameter m_rnrStyle;
FWBoolParameter m_clipParam;
FWBoolParameter m_selectable;
Expand Down
1 change: 1 addition & 0 deletions Fireworks/Core/interface/FWConfiguration.h
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ class FWConfiguration
FWConfiguration& addValue(const std::string&);
void swap(FWConfiguration& );

static void streamTo(std::ostream& oTo, const FWConfiguration& iConfig, const std::string &name);

private:

Expand Down
4 changes: 2 additions & 2 deletions Fireworks/Core/interface/FWConfigurationManager.h
Original file line number Diff line number Diff line change
Expand Up @@ -42,14 +42,14 @@ class FWConfigurationManager

void writeToFile(const std::string&) const;
void readFromFile(const std::string&) const;
void guessAndReadFromFile(FWJobMetadataManager*) const;
std::string guessAndReadFromFile(FWJobMetadataManager*) const;
// ---------- static member functions --------------------

// ---------- member functions ---------------------------
///does not take ownership
void add(const std::string& iName, FWConfigurable*);

void setIgnore() { m_ignore = false; }
void setIgnore() { m_ignore = true; }
bool getIgnore() const { return m_ignore; }

private:
Expand Down
2 changes: 1 addition & 1 deletion Fireworks/Core/interface/FWFileEntry.h
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// -*- C++ -*-
#ifndef Fireworks_Core_FWFileEntry_h
#define Fireworks_Core_FWFileEntryr_h
#define Fireworks_Core_FWFileEntry_h
//
// Package: Core
// Class : FWFileEntry
Expand Down
5 changes: 5 additions & 0 deletions Fireworks/Core/interface/FWGUIEventFilter.h
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@

#ifndef Fireworks_Core_GUIEventFilter_h
#define Fireworks_Core_GUIEventFilter_h

#include <list>

#include "TGFrame.h"
Expand Down Expand Up @@ -79,3 +83,4 @@ class FWGUIEventFilter: public TGMainFrame
CmsShowNavigator* m_navigator;
};

#endif
5 changes: 5 additions & 0 deletions Fireworks/Core/interface/FWGUIManager.h
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,9 @@ class FWGUIManager : public FWConfigurable
sigc::signal<void> filterButtonClicked_;
sigc::signal<void, const TGWindow*> showEventFilterGUI_;
sigc::signal<void, const std::string&> writeToConfigurationFile_;
sigc::signal<void, const std::string&> writePartialToConfigurationFile_;
sigc::signal<void, const std::string&> loadFromConfigurationFile_;
sigc::signal<void, const std::string&> loadPartialFromConfigurationFile_;
sigc::signal<void, edm::RunNumber_t, edm::LuminosityBlockNumber_t, edm::EventNumber_t> changedEventId_;
sigc::signal<void> goingToQuit_;
sigc::signal<void> writeToPresentConfigurationFile_;
Expand All @@ -224,7 +226,10 @@ class FWGUIManager : public FWConfigurable

bool promptForConfigurationFile(std::string &result, enum EFileDialogMode mode);
void promptForSaveConfigurationFile();
void promptForPartialSaveConfigurationFile();
void promptForLoadConfigurationFile();
void promptForPartialLoadConfigurationFile();
void savePartialToConfigurationFile();

void delaySliderChanged(Int_t);

Expand Down
72 changes: 0 additions & 72 deletions Fireworks/Core/interface/FWHandle.h

This file was deleted.

7 changes: 1 addition & 6 deletions Fireworks/Core/interface/FWISpyView.h
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
#include "Fireworks/Core/interface/FW3DViewBase.h"

// forward declarations
class TEveBoxSet;

class FWISpyView : public FW3DViewBase
{
Expand All @@ -34,7 +33,6 @@ class FWISpyView : public FW3DViewBase
virtual void setContext(const fireworks::Context& x);

virtual void populateController(ViewerParameterGUI&) const;
void showEcalBarrel(bool);
// ---------- const member functions ---------------------

// ---------- static member functions --------------------
Expand All @@ -46,10 +44,7 @@ class FWISpyView : public FW3DViewBase

const FWISpyView& operator=(const FWISpyView&); // stop default

// ---------- member data --------------------------------
TEveBoxSet* m_ecalBarrel;
FWBoolParameter m_showEcalBarrel;
// ---------- member data --------------------------------};
};


#endif
61 changes: 61 additions & 0 deletions Fireworks/Core/interface/FWPartialConfig.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,61 @@
#ifndef Fireworks_Core_FWPartialConfig
#define Fireworks_Core_FWPartialConfig
#include <TGFrame.h>
#include <vector>
#include "Fireworks/Core/interface/FWConfiguration.h"

class TGCheckButton;
class FWConfigurationManager;
class FWEventItemsManager;

class FWPartialConfigGUI : public TGTransientFrame
{
public:
FWPartialConfigGUI(const char* path, FWConfigurationManager*);
~FWPartialConfigGUI() {}
void Cancel();

protected:
std::vector <TGCheckButton*> m_entries;
FWConfiguration m_origConfig;
FWConfigurationManager* m_cfgMng;

ClassDef(FWPartialConfigGUI, 0);
};

//---------------------------------------------------------------------

class FWPartialConfigLoadGUI : public FWPartialConfigGUI
{
public:
FWPartialConfigLoadGUI( const char* path, FWConfigurationManager* ,FWEventItemsManager*);
~FWPartialConfigLoadGUI();

void Load();

private:
FWEventItemsManager* m_eiMng;
const char* m_oldConfigName;
ClassDef(FWPartialConfigLoadGUI, 0);
};


//---------------------------------------------------------------------

class FWPartialConfigSaveGUI : public FWPartialConfigGUI
{
public:
FWPartialConfigSaveGUI( const char* path_out,const char* path_in, FWConfigurationManager* );
~FWPartialConfigSaveGUI() {}

void Write();

private:
std::string m_outFileName;
std::string m_currFileName;

ClassDef(FWPartialConfigSaveGUI, 0);
};


#endif
Loading

0 comments on commit ab1a44b

Please sign in to comment.