[RECONSTRUCTION-UPGRADE] Changes suggested by new llvm18 clang-format

cms-sw · Sep 5, 2024 · 9e8dfa3 · 9e8dfa3
1 parent 15ea9bb
commit 9e8dfa3
Show file tree

Hide file tree

Showing 47 changed files with 65 additions and 65 deletions.
diff --git a/RecoHGCal/TICL/interface/TICLInterpretationAlgoBase.h b/RecoHGCal/TICL/interface/TICLInterpretationAlgoBase.h
@@ -34,7 +34,7 @@ namespace ticl {
   public:
     TICLInterpretationAlgoBase(const edm::ParameterSet& conf, edm::ConsumesCollector)
         : algo_verbosity_(conf.getParameter<int>("algo_verbosity")) {}
-    virtual ~TICLInterpretationAlgoBase(){};
+    virtual ~TICLInterpretationAlgoBase() {}
     struct Inputs {
       const edm::Event& ev;
       const edm::EventSetup& es;

diff --git a/RecoHGCal/TICL/interface/TracksterLinkingAlgoBase.h b/RecoHGCal/TICL/interface/TracksterLinkingAlgoBase.h
@@ -46,7 +46,7 @@ namespace ticl {
                              edm::ConsumesCollector,
                              cms::Ort::ONNXRuntime const* onnxRuntime = nullptr)
         : algo_verbosity_(conf.getParameter<int>("algo_verbosity")), onnxRuntime_(onnxRuntime) {}
-    virtual ~TracksterLinkingAlgoBase(){};
+    virtual ~TracksterLinkingAlgoBase() {}
 
     struct Inputs {
       const edm::Event& ev;
@@ -74,7 +74,7 @@ namespace ticl {
                             const edm::ESHandle<Propagator> propH) = 0;
 
     // To be called by TracksterLinksProducer at the start of TracksterLinksProducer::produce. Subclasses can use this to store Event and EventSetup
-    virtual void setEvent(edm::Event& iEvent, edm::EventSetup const& iEventSetup){};
+    virtual void setEvent(edm::Event& iEvent, edm::EventSetup const& iEventSetup) {}
 
     static void fillPSetDescription(edm::ParameterSetDescription& desc) { desc.add<int>("algo_verbosity", 0); };
 

diff --git a/RecoHGCal/TICL/plugins/ClusterFilterBase.h b/RecoHGCal/TICL/plugins/ClusterFilterBase.h
@@ -20,8 +20,8 @@ namespace reco {
 namespace ticl {
   class ClusterFilterBase {
   public:
-    explicit ClusterFilterBase(const edm::ParameterSet&){};
-    virtual ~ClusterFilterBase(){};
+    explicit ClusterFilterBase(const edm::ParameterSet&) {}
+    virtual ~ClusterFilterBase() {}
 
     virtual void filter(const std::vector<reco::CaloCluster>& layerClusters,
                         std::vector<float>& layerClustersMask,

diff --git a/RecoHGCal/TICL/plugins/ClusterFilterByAlgo.h b/RecoHGCal/TICL/plugins/ClusterFilterByAlgo.h
@@ -16,7 +16,7 @@ namespace ticl {
   public:
     ClusterFilterByAlgo(const edm::ParameterSet& ps)
         : ClusterFilterBase(ps), algo_number_(ps.getParameter<std::vector<int>>("algo_number")) {}
-    ~ClusterFilterByAlgo() override{};
+    ~ClusterFilterByAlgo() override {}
 
     void filter(const std::vector<reco::CaloCluster>& layerClusters,
                 std::vector<float>& layerClustersMask,

diff --git a/RecoHGCal/TICL/plugins/ClusterFilterByAlgoAndSize.h b/RecoHGCal/TICL/plugins/ClusterFilterByAlgoAndSize.h
@@ -20,7 +20,7 @@ namespace ticl {
               "algo_number")),  // hgcal_em = 6, hgcal_had = 7, hgcal_scintillator = 8, hfnose = 9
           min_cluster_size_(ps.getParameter<int>("min_cluster_size")),
           max_cluster_size_(ps.getParameter<int>("max_cluster_size")) {}
-    ~ClusterFilterByAlgoAndSize() override{};
+    ~ClusterFilterByAlgoAndSize() override {}
 
     void filter(const std::vector<reco::CaloCluster>& layerClusters,
                 std::vector<float>& layerClustersMask,

diff --git a/RecoHGCal/TICL/plugins/ClusterFilterByAlgoAndSizeAndLayerRange.h b/RecoHGCal/TICL/plugins/ClusterFilterByAlgoAndSizeAndLayerRange.h
@@ -21,7 +21,7 @@ namespace ticl {
           max_cluster_size_(ps.getParameter<int>("max_cluster_size")),
           min_layerId_(ps.getParameter<int>("min_layerId")),
           max_layerId_(ps.getParameter<int>("max_layerId")) {}
-    ~ClusterFilterByAlgoAndSizeAndLayerRange() override{};
+    ~ClusterFilterByAlgoAndSizeAndLayerRange() override {}
 
     void filter(const std::vector<reco::CaloCluster>& layerClusters,
                 std::vector<float>& layerClustersMask,

diff --git a/RecoHGCal/TICL/plugins/ClusterFilterBySize.h b/RecoHGCal/TICL/plugins/ClusterFilterBySize.h
@@ -16,7 +16,7 @@ namespace ticl {
   public:
     ClusterFilterBySize(const edm::ParameterSet& ps)
         : ClusterFilterBase(ps), max_cluster_size_(ps.getParameter<int>("max_cluster_size")) {}
-    ~ClusterFilterBySize() override{};
+    ~ClusterFilterBySize() override {}
 
     void filter(const std::vector<reco::CaloCluster>& layerClusters,
                 std::vector<float>& layerClustersMask,

diff --git a/RecoHGCal/TICL/plugins/GeneralInterpretationAlgo.cc b/RecoHGCal/TICL/plugins/GeneralInterpretationAlgo.cc
@@ -7,7 +7,7 @@ using namespace ticl;
 
 using Vector = ticl::Trackster::Vector;
 
-GeneralInterpretationAlgo::~GeneralInterpretationAlgo(){};
+GeneralInterpretationAlgo::~GeneralInterpretationAlgo() {}
 
 GeneralInterpretationAlgo::GeneralInterpretationAlgo(const edm::ParameterSet &conf, edm::ConsumesCollector cc)
     : TICLInterpretationAlgoBase(conf, cc),

diff --git a/RecoHGCal/TICL/plugins/LinkingAlgoBase.h b/RecoHGCal/TICL/plugins/LinkingAlgoBase.h
@@ -25,7 +25,7 @@ namespace ticl {
   public:
     LinkingAlgoBase(const edm::ParameterSet& conf) : algo_verbosity_(conf.getParameter<int>("algo_verbosity")) {}
 
-    virtual ~LinkingAlgoBase(){};
+    virtual ~LinkingAlgoBase() {}
 
     virtual void initialize(const HGCalDDDConstants* hgcons,
                             const hgcal::RecHitTools rhtools,

diff --git a/RecoHGCal/TICL/plugins/MergedTrackstersProducer.cc b/RecoHGCal/TICL/plugins/MergedTrackstersProducer.cc
@@ -16,7 +16,7 @@ using namespace ticl;
 class MergedTrackstersProducer : public edm::stream::EDProducer<> {
 public:
   explicit MergedTrackstersProducer(const edm::ParameterSet &ps);
-  ~MergedTrackstersProducer() override{};
+  ~MergedTrackstersProducer() override {}
   void produce(edm::Event &, const edm::EventSetup &) override;
   static void fillDescriptions(edm::ConfigurationDescriptions &descriptions);
 

diff --git a/RecoHGCal/TICL/plugins/SeedingRegionAlgoBase.h b/RecoHGCal/TICL/plugins/SeedingRegionAlgoBase.h
@@ -23,7 +23,7 @@ namespace ticl {
   public:
     SeedingRegionAlgoBase(const edm::ParameterSet& conf, edm::ConsumesCollector& sumes)
         : algo_verbosity_(conf.getParameter<int>("algo_verbosity")) {}
-    virtual ~SeedingRegionAlgoBase(){};
+    virtual ~SeedingRegionAlgoBase() {}
 
     virtual void initialize(const edm::EventSetup& es) = 0;
 

diff --git a/RecoHGCal/TICL/plugins/SeedingRegionByL1.h b/RecoHGCal/TICL/plugins/SeedingRegionByL1.h
@@ -24,7 +24,7 @@ namespace ticl {
   public:
     SeedingRegionByL1(const edm::ParameterSet& conf, edm::ConsumesCollector& sumes);
 
-    void initialize(const edm::EventSetup& es) override{};
+    void initialize(const edm::EventSetup& es) override {}
     void makeRegions(const edm::Event& ev, const edm::EventSetup& es, std::vector<TICLSeedingRegion>& result) override;
     static void fillPSetDescription(edm::ParameterSetDescription& desc);
 

diff --git a/RecoHGCal/TICL/plugins/SeedingRegionGlobal.cc b/RecoHGCal/TICL/plugins/SeedingRegionGlobal.cc
@@ -15,7 +15,7 @@ using namespace ticl;
 SeedingRegionGlobal::SeedingRegionGlobal(const edm::ParameterSet &conf, edm::ConsumesCollector &sumes)
     : SeedingRegionAlgoBase(conf, sumes) {}
 
-SeedingRegionGlobal::~SeedingRegionGlobal(){};
+SeedingRegionGlobal::~SeedingRegionGlobal() {}
 
 void SeedingRegionGlobal::makeRegions(const edm::Event &ev,
                                       const edm::EventSetup &es,

diff --git a/RecoHGCal/TICL/plugins/SeedingRegionGlobal.h b/RecoHGCal/TICL/plugins/SeedingRegionGlobal.h
@@ -22,7 +22,7 @@ namespace ticl {
     SeedingRegionGlobal(const edm::ParameterSet& conf, edm::ConsumesCollector& sumes);
     ~SeedingRegionGlobal() override;
 
-    void initialize(const edm::EventSetup& es) override{};
+    void initialize(const edm::EventSetup& es) override {}
 
     void makeRegions(const edm::Event& ev, const edm::EventSetup& es, std::vector<TICLSeedingRegion>& result) override;
 

diff --git a/RecoHGCal/TICL/plugins/TICLCandidateProducer.cc b/RecoHGCal/TICL/plugins/TICLCandidateProducer.cc
@@ -58,7 +58,7 @@ using namespace ticl;
 class TICLCandidateProducer : public edm::stream::EDProducer<> {
 public:
   explicit TICLCandidateProducer(const edm::ParameterSet &ps);
-  ~TICLCandidateProducer() override{};
+  ~TICLCandidateProducer() override {}
   void produce(edm::Event &, const edm::EventSetup &) override;
   static void fillDescriptions(edm::ConfigurationDescriptions &descriptions);
 

diff --git a/RecoHGCal/TICL/plugins/TICLLayerTileProducer.cc b/RecoHGCal/TICL/plugins/TICLLayerTileProducer.cc
@@ -17,7 +17,7 @@
 class TICLLayerTileProducer : public edm::stream::EDProducer<> {
 public:
   explicit TICLLayerTileProducer(const edm::ParameterSet &ps);
-  ~TICLLayerTileProducer() override{};
+  ~TICLLayerTileProducer() override {}
   void beginRun(edm::Run const &, edm::EventSetup const &) override;
   void produce(edm::Event &, const edm::EventSetup &) override;
   static void fillDescriptions(edm::ConfigurationDescriptions &descriptions);

diff --git a/RecoHGCal/TICL/plugins/TracksterLinkingbyFastJet.h b/RecoHGCal/TICL/plugins/TracksterLinkingbyFastJet.h
@@ -45,7 +45,7 @@ namespace ticl {
     void initialize(const HGCalDDDConstants* hgcons,
                     const hgcal::RecHitTools rhtools,
                     const edm::ESHandle<MagneticField> bfieldH,
-                    const edm::ESHandle<Propagator> propH) override{};
+                    const edm::ESHandle<Propagator> propH) override {};
 
     static void fillPSetDescription(edm::ParameterSetDescription& iDesc) {
       iDesc.add<int>("algo_verbosity", 0);

diff --git a/RecoHGCal/TICL/plugins/TrackstersMergeProducer.cc b/RecoHGCal/TICL/plugins/TrackstersMergeProducer.cc
@@ -53,7 +53,7 @@ using namespace ticl;
 class TrackstersMergeProducer : public edm::stream::EDProducer<> {
 public:
   explicit TrackstersMergeProducer(const edm::ParameterSet &ps);
-  ~TrackstersMergeProducer() override{};
+  ~TrackstersMergeProducer() override {}
   void produce(edm::Event &, const edm::EventSetup &) override;
   static void fillDescriptions(edm::ConfigurationDescriptions &descriptions);
 
@@ -198,7 +198,7 @@ TrackstersMergeProducer::TrackstersMergeProducer(const edm::ParameterSet &ps)
 
 void TrackstersMergeProducer::beginJob() {}
 
-void TrackstersMergeProducer::endJob(){};
+void TrackstersMergeProducer::endJob() {}
 
 void TrackstersMergeProducer::beginRun(edm::Run const &iEvent, edm::EventSetup const &es) {
   edm::ESHandle<HGCalDDDConstants> hdc = es.getHandle(hdc_token_);

diff --git a/RecoHGCal/TICL/test/TiclDebugger.cc b/RecoHGCal/TICL/test/TiclDebugger.cc
@@ -46,7 +46,7 @@ class TiclDebugger : public edm::one::EDAnalyzer<edm::one::WatchRuns> {
   void beginJob() override;
   void beginRun(const edm::Run&, const edm::EventSetup&) override;
   void analyze(const edm::Event&, const edm::EventSetup&) override;
-  void endRun(edm::Run const& iEvent, edm::EventSetup const&) override{};
+  void endRun(edm::Run const& iEvent, edm::EventSetup const&) override {}
   void endJob() override;
 
   const edm::InputTag trackstersMerge_;

diff --git a/RecoLocalCalo/HGCalRecAlgos/interface/HGCalRecHitAbsAlgo.h b/RecoLocalCalo/HGCalRecAlgos/interface/HGCalRecHitAbsAlgo.h
@@ -20,12 +20,12 @@ class HGCalRecHitAbsAlgo {
   //HGCalRecHitAbsAlgo() { };
 
   /// Destructor
-  virtual ~HGCalRecHitAbsAlgo(){};
+  virtual ~HGCalRecHitAbsAlgo() {}
 
   inline void set(const CaloGeometry& geom) { rhtools_.setGeometry(geom); }
 
   /// make rechits from dataframes
-  virtual void setLayerWeights(const std::vector<float>& weights){};
+  virtual void setLayerWeights(const std::vector<float>& weights) {}
 
   virtual void setADCToGeVConstant(const float value) = 0;
   virtual HGCRecHit makeRecHit(const HGCUncalibratedRecHit& uncalibRH, const uint32_t& flags) const = 0;

diff --git a/RecoLocalCalo/HGCalRecAlgos/interface/HGCalRecHitSimpleAlgo.h b/RecoLocalCalo/HGCalRecAlgos/interface/HGCalRecHitSimpleAlgo.h
@@ -36,7 +36,7 @@ class HGCalRecHitSimpleAlgo : public HGCalRecHitAbsAlgo {
   }
 
   // destructor
-  ~HGCalRecHitSimpleAlgo() override{};
+  ~HGCalRecHitSimpleAlgo() override {}
 
   /// Compute parameters
   HGCRecHit makeRecHit(const HGCUncalibratedRecHit& uncalibRH, const uint32_t& flags = 0) const override {

diff --git a/RecoLocalCalo/HGCalRecAlgos/interface/HGCalUncalibRecHitRecWeightsAlgo.h b/RecoLocalCalo/HGCalRecAlgos/interface/HGCalUncalibRecHitRecWeightsAlgo.h
@@ -21,7 +21,7 @@ template <class C>
 class HGCalUncalibRecHitRecWeightsAlgo {
 public:
   // destructor
-  virtual ~HGCalUncalibRecHitRecWeightsAlgo(){};
+  virtual ~HGCalUncalibRecHitRecWeightsAlgo() {}
 
   void set_isSiFESim(const bool isSiFE) { isSiFESim_ = isSiFE; }
   bool isSiFESim() const { return isSiFESim_; }
@@ -74,8 +74,8 @@ class HGCalUncalibRecHitRecWeightsAlgo {
         amplitude_ = (std::floor(tdcOnsetfC_ / adcLSB_) + 1.0) * adcLSB_ + (double(sample.data()) + 0.5) * tdcLSB_;
       } else {
         amplitude_ = double(sample.data()) * adcLSB_;  // why do we not have +0.5 here ?
-      }                                                //isSiFESim_
-    }                                                  //mode()
+      }  //isSiFESim_
+    }  //mode()
 
     // trivial digitization, i.e. no signal shape
     else {

diff --git a/RecoLocalCalo/HGCalRecAlgos/src/HGCalDepthPreClusterer.cc b/RecoLocalCalo/HGCalRecAlgos/src/HGCalDepthPreClusterer.cc
@@ -56,7 +56,7 @@ std::vector<reco::HGCalMultiCluster> HGCalDepthPreClusterer::makePreClusters(
           else if (layer < rhtools_.firstLayerBH())
             radius = radii[1];
           float radius2 = radius * radius;
-          if (distanceCheck<radius2 &&int(thecls[es[j]]->z() * vused[i])> 0) {
+          if (distanceCheck < radius2 && int(thecls[es[j]]->z() * vused[i]) > 0) {
             temp.push_back(thecls[es[j]]);
             vused[j] = vused[i];
           }

diff --git a/RecoLocalCalo/HGCalRecProducers/interface/HGCalImagingAlgo.h b/RecoLocalCalo/HGCalRecProducers/interface/HGCalImagingAlgo.h
@@ -239,7 +239,7 @@ class HGCalImagingAlgo : public HGCalClusteringAlgoBase {
     const double dx = pt1.x - pt2.x;
     const double dy = pt1.y - pt2.y;
     return (dx * dx + dy * dy);
-  }                                                                   //distance squaredq
+  }  //distance squaredq
   inline double distance(const Hexel &pt1, const Hexel &pt2) const {  //2-d distance on the layer (x-y)
     return std::sqrt(distance2(pt1, pt2));
   }

diff --git a/RecoLocalCalo/HGCalRecProducers/plugins/HGCalImagingAlgo.cc b/RecoLocalCalo/HGCalRecProducers/plugins/HGCalImagingAlgo.cc
@@ -284,7 +284,7 @@ double HGCalImagingAlgo::calculateLocalDensity(std::vector<KDNode> &nd, KDTree &
         maxdensity = std::max(maxdensity, nd[i].data.rho);
       }
     }  // end loop found
-  }    // end loop nodes
+  }  // end loop nodes
   return maxdensity;
 }
 

diff --git a/RecoLocalCalo/HGCalRecProducers/plugins/HGCalUncalibRecHitWorkerWeights.h b/RecoLocalCalo/HGCalRecProducers/plugins/HGCalUncalibRecHitWorkerWeights.h
@@ -25,7 +25,7 @@ namespace edm {
 class HGCalUncalibRecHitWorkerWeights : public HGCalUncalibRecHitWorkerBaseClass {
 public:
   HGCalUncalibRecHitWorkerWeights(const edm::ParameterSet&, edm::ConsumesCollector iC, bool useTime);
-  ~HGCalUncalibRecHitWorkerWeights() override{};
+  ~HGCalUncalibRecHitWorkerWeights() override {}
 
   bool runHGCEE(const edm::ESHandle<HGCalGeometry>& geom,
                 const HGCalDigiCollection& digis,

diff --git a/RecoLocalCalo/HGCalRecProducers/src/ComputeClusterTime.cc b/RecoLocalCalo/HGCalRecProducers/src/ComputeClusterTime.cc
@@ -27,7 +27,7 @@ ComputeClusterTime::ComputeClusterTime(float Xmin, float Xmax, float Cterm, floa
     xMin_ = 0.1;
 };
 
-ComputeClusterTime::ComputeClusterTime() : xMin_(1.), xMax_(5.), cTerm_(0), aTerm_(0){};
+ComputeClusterTime::ComputeClusterTime() : xMin_(1.), xMax_(5.), cTerm_(0), aTerm_(0) {}
 
 void ComputeClusterTime::setParameters(float Xmin, float Xmax, float Cterm, float Aterm) {
   xMin_ = (Xmin > 0) ? Xmin : 0.1;

diff --git a/RecoLocalFastTime/FTLClusterizer/interface/MTDClusterParameterEstimator.h b/RecoLocalFastTime/FTLClusterizer/interface/MTDClusterParameterEstimator.h
@@ -54,7 +54,7 @@ class MTDClusterParameterEstimator {
     return vlp;
   }
 
-  MTDClusterParameterEstimator(){};
+  MTDClusterParameterEstimator() {}
 };
 
 #endif
diff --git a/RecoLocalFastTime/FTLCommonAlgos/interface/MTDRecHitAlgoBase.h b/RecoLocalFastTime/FTLCommonAlgos/interface/MTDRecHitAlgoBase.h
@@ -22,10 +22,10 @@ class MTDRecHitAlgoBase {
 public:
   /// Constructor
   MTDRecHitAlgoBase(const edm::ParameterSet& conf, edm::ConsumesCollector& sumes)
-      : name_(conf.getParameter<std::string>("algoName")){};
+      : name_(conf.getParameter<std::string>("algoName")) {}
 
   /// Destructor
-  virtual ~MTDRecHitAlgoBase(){};
+  virtual ~MTDRecHitAlgoBase() {}
 
   /// get event and eventsetup information
   virtual void getEvent(const edm::Event&) = 0;

diff --git a/RecoLocalFastTime/FTLCommonAlgos/interface/MTDTimeCalib.h b/RecoLocalFastTime/FTLCommonAlgos/interface/MTDTimeCalib.h
@@ -12,7 +12,7 @@ class MTDTimeCalib {
 public:
   //constructor & destructor
   MTDTimeCalib(edm::ParameterSet const& conf, const MTDGeometry* geom, const MTDTopology* topo);
-  ~MTDTimeCalib(){};
+  ~MTDTimeCalib() {}
 
   //accessors
   float getTimeCalib(const MTDDetId& id) const;

diff --git a/RecoLocalFastTime/FTLRecProducers/plugins/MTDTrackingRecHitProducer.cc b/RecoLocalFastTime/FTLRecProducers/plugins/MTDTrackingRecHitProducer.cc
@@ -124,7 +124,7 @@ void MTDTrackingRecHitProducer::produce(edm::StreamID, edm::Event& evt, const ed
         // Now save it =================
         recHitsOnDet.push_back(hit);
       }  //  <-- End loop on Clusters
-    }    //    <-- End loop on DetUnits
+    }  //    <-- End loop on DetUnits
     LogDebug("MTDTrackingRecHitProducer") << "outputCollection " << theoutputhits.size();
   }
 

diff --git a/RecoLocalMuon/GEMCSCSegment/plugins/GEMCSCSegFit.h b/RecoLocalMuon/GEMCSCSegment/plugins/GEMCSCSegFit.h
@@ -140,7 +140,7 @@ class GEMCSCSegFit {
     // Test whether id is found
     if (csclayermap_.find(id) == csclayermap_.end()) {  // id is not found
       throw cms::Exception("InvalidDetId") << "[GEMCSCSegFit] Failed to find CSCChamber in CSCLayerMap" << std::endl;
-    }       // chamber is not found and exception is thrown
+    }  // chamber is not found and exception is thrown
     else {  // id is found
       return (csclayermap_.find(id)->second)->chamber();
     }  // chamber found and returned

diff --git a/RecoLocalMuon/GEMCSCSegment/plugins/GEMCSCSegmentAlgorithm.h b/RecoLocalMuon/GEMCSCSegment/plugins/GEMCSCSegmentAlgorithm.h
@@ -27,9 +27,9 @@
 class GEMCSCSegmentAlgorithm {
 public:
   /// Constructor
-  explicit GEMCSCSegmentAlgorithm(const edm::ParameterSet&){};
+  explicit GEMCSCSegmentAlgorithm(const edm::ParameterSet&) {}
   /// Destructor
-  virtual ~GEMCSCSegmentAlgorithm(){};
+  virtual ~GEMCSCSegmentAlgorithm() {}
   /// Run the algorithm = build segments
   virtual std::vector<GEMCSCSegment> run(const std::map<uint32_t, const CSCLayer*>& csclayermap,
                                          const std::map<uint32_t, const GEMEtaPartition*>& gemrollmap,

diff --git a/RecoLocalMuon/GEMCSCSegment/plugins/GEMCSCSegmentBuilder.cc b/RecoLocalMuon/GEMCSCSegment/plugins/GEMCSCSegmentBuilder.cc
@@ -213,8 +213,8 @@ void GEMCSCSegmentBuilder::build(const GEMRecHitCollection* recHits,
                 << "] added to CSC segment found in " << CSCId << " [" << CSCId.rawId() << "]" << std::endl;
           }
         }  // end Loop over GEM Rolls
-      }    // end Loop over GEM RecHits
-    }      // end requirement of CSC segment in ME1/1 or ME2/1
+      }  // end Loop over GEM RecHits
+    }  // end requirement of CSC segment in ME1/1 or ME2/1
 
     // Case B :: all other CSC Chambers have no GEM Chamber associated
     // ===============================================================

diff --git a/RecoLocalMuon/GEMCSCSegment/plugins/GEMCSCSegmentBuilder.h b/RecoLocalMuon/GEMCSCSegment/plugins/GEMCSCSegmentBuilder.h
@@ -31,7 +31,7 @@
 
 class CSCStationIndex {
 public:
-  CSCStationIndex() : _region(0), _station(0), _ring(0), _chamber(0), _layer(0){};
+  CSCStationIndex() : _region(0), _station(0), _ring(0), _chamber(0), _layer(0) {}
   CSCStationIndex(int region, int station, int ring, int chamber, int layer)
       : _region(region), _station(station), _ring(ring), _chamber(chamber), _layer(layer) {}
   ~CSCStationIndex() {}

diff --git a/RecoLocalMuon/GEMCSCSegment/test/GEMCSCCoincidenceRateAnalyzer.cc b/RecoLocalMuon/GEMCSCSegment/test/GEMCSCCoincidenceRateAnalyzer.cc
@@ -269,9 +269,9 @@ std::vector<const CSCSegment*> GEMCSCCoincidenceRateAnalyzer::findMuonSegments(
             break;
           }
         }  // MuonSegmentMatch
-      }    // checkCSCChamberType
-    }      // MuonChamberMatch
-  }        // MuonCollection
+      }  // checkCSCChamberType
+    }  // MuonChamberMatch
+  }  // MuonCollection
 
   return muon_segment_vec;
 }
@@ -324,8 +324,8 @@ bool GEMCSCCoincidenceRateAnalyzer::checkGEMChamberStatus(const GEMDetId& chambe
         // GEMOHStatus is bad. Mask this chamber.
         return has_error;
       }  // isBad
-    }    // range
-  }      // collection
+    }  // range
+  }  // collection
 
   for (auto iter = vfat_status_collection->begin(); iter != vfat_status_collection->end(); iter++) {
     const auto [vfat_id, range] = (*iter);
@@ -337,7 +337,7 @@ bool GEMCSCCoincidenceRateAnalyzer::checkGEMChamberStatus(const GEMDetId& chambe
         return has_error;
       }
     }  // range
-  }    // collection
+  }  // collection
 
   return not has_error;
 }