Do not check exceptionPtr() against nullptr anymore

The function now returns an std::exception_ptr by value not by pointer anymore.
cms-sw · Jul 15, 2022 · 7a502ff · 7a502ff
1 parent 367c624
commit 7a502ff
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/FWCore/Concurrency/interface/WaitingTaskHolder.h b/FWCore/Concurrency/interface/WaitingTaskHolder.h
@@ -69,7 +69,7 @@ namespace edm {
     }
 
     // ---------- const member functions ---------------------
-    bool taskHasFailed() const noexcept { return m_task->exceptionPtr() != nullptr; }
+    bool taskHasFailed() const noexcept { return static_cast<bool>(m_task->exceptionPtr()); }
 
     bool hasTask() const noexcept { return m_task != nullptr; }
     /** since oneapi::tbb::task_group is thread safe, we can return it non-const from here since

diff --git a/FWCore/Concurrency/src/WaitingTaskWithArenaHolder.cc b/FWCore/Concurrency/src/WaitingTaskWithArenaHolder.cc
@@ -109,7 +109,7 @@ namespace edm {
     return holder;
   }
 
-  bool WaitingTaskWithArenaHolder::taskHasFailed() const noexcept { return m_task->exceptionPtr() != nullptr; }
+  bool WaitingTaskWithArenaHolder::taskHasFailed() const noexcept { return static_cast<bool>(m_task->exceptionPtr()); }
 
   bool WaitingTaskWithArenaHolder::hasTask() const noexcept { return m_task != nullptr; }