Merge pull request #34205 from mrodozov/update-catch2

Cast indexFor to unsigned for size comparison
cms-sw · Jun 23, 2021 · 5aa4fde · 5aa4fde
2 parents 71cd6b9 + 8af1172
commit 5aa4fde
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/CondFormats/EcalObjects/test/EcalPulseSymmCovariance_catch2.cc b/CondFormats/EcalObjects/test/EcalPulseSymmCovariance_catch2.cc
@@ -42,7 +42,7 @@ TEST_CASE("EcalPulseSymmCovariance testing", "[EcalPulseSymmCovariance]") {
   SECTION("Check bounds") {
     for (int i = 0; i < EcalPulseShape::TEMPLATESAMPLES; ++i) {
       for (int j = 0; j < EcalPulseShape::TEMPLATESAMPLES; ++j) {
-        REQUIRE(cov.indexFor(i, j) < std::size(cov.covval));
+        REQUIRE((unsigned)cov.indexFor(i, j) < std::size(cov.covval));
       }
     }
   }

diff --git a/FWCore/Framework/test/test_catch2notTP_ESRecordsToProxyIndices.cc b/FWCore/Framework/test/test_catch2notTP_ESRecordsToProxyIndices.cc
@@ -84,7 +84,7 @@ TEST_CASE("test ESRecordsToProxyIndices", "[ESRecordsToProxyIndices]") {
       index = 0;
       auto it = pr.second.second.begin();
       for (auto const& dk : pr.second.first) {
-        REQUIRE(index == r2pi.indexInRecord(pr.first, dk).value());
+        REQUIRE(index == (unsigned)r2pi.indexInRecord(pr.first, dk).value());
         REQUIRE(*it == r2pi.component(pr.first, dk));
         ++index;
         ++it;