set parameter defaults in LumiMonitor

cms-sw · Dec 20, 2022 · 51154dc · 51154dc
1 parent f5e9024
commit 51154dc
Showing 1 changed file with 29 additions and 18 deletions.
diff --git a/DQM/HLTEvF/plugins/LumiMonitor.cc b/DQM/HLTEvF/plugins/LumiMonitor.cc
@@ -43,9 +43,14 @@ class LumiMonitor : public DQMGlobalEDAnalyzer<Histograms> {
 public:
   LumiMonitor(const edm::ParameterSet&);
   ~LumiMonitor() override = default;
+
   static void fillDescriptions(edm::ConfigurationDescriptions& descriptions);
-  static void fillHistoPSetDescription(edm::ParameterSetDescription& pset);
-  static void fillHistoLSPSetDescription(edm::ParameterSetDescription& pset);
+
+  static void fillHistoPSetDescription(edm::ParameterSetDescription& pset,
+                                       int const nbins,
+                                       double const xmin,
+                                       double const xmax);
+  static void fillHistoLSPSetDescription(edm::ParameterSetDescription& pset, int const nbins);
 
 private:
   void bookHistograms(DQMStore::IBooker&, edm::Run const&, edm::EventSetup const&, Histograms&) const override;
@@ -250,13 +255,18 @@ void LumiMonitor::dqmAnalyze(edm::Event const& event,
   }
 }
 
-void LumiMonitor::fillHistoPSetDescription(edm::ParameterSetDescription& pset) {
-  pset.add<int>("nbins");
-  pset.add<double>("xmin");
-  pset.add<double>("xmax");
+void LumiMonitor::fillHistoPSetDescription(edm::ParameterSetDescription& pset,
+                                           int const nbins,
+                                           double const xmin,
+                                           double const xmax) {
+  pset.add<int>("nbins", nbins);
+  pset.add<double>("xmin", xmin);
+  pset.add<double>("xmax", xmax);
 }
 
-void LumiMonitor::fillHistoLSPSetDescription(edm::ParameterSetDescription& pset) { pset.add<int>("nbins", 2500); }
+void LumiMonitor::fillHistoLSPSetDescription(edm::ParameterSetDescription& pset, int const nbins) {
+  pset.add<int>("nbins", nbins);
+}
 
 void LumiMonitor::fillDescriptions(edm::ConfigurationDescriptions& descriptions) {
   edm::ParameterSetDescription desc;
@@ -270,25 +280,26 @@ void LumiMonitor::fillDescriptions(edm::ConfigurationDescriptions& descriptions)
   desc.add<double>("minPixelClusterCharge", 15000.);
 
   edm::ParameterSetDescription histoPSet;
-  edm::ParameterSetDescription pixelClusterPSet;
-  LumiMonitor::fillHistoPSetDescription(pixelClusterPSet);
-  histoPSet.add("pixelClusterPSet", pixelClusterPSet);
 
-  edm::ParameterSetDescription lumiPSet;
-  fillHistoPSetDescription(lumiPSet);
-  histoPSet.add<edm::ParameterSetDescription>("lumiPSet", lumiPSet);
+  edm::ParameterSetDescription lsPSet;
+  fillHistoLSPSetDescription(lsPSet, 2500);
+  histoPSet.add<edm::ParameterSetDescription>("lsPSet", lsPSet);
 
   edm::ParameterSetDescription puPSet;
-  fillHistoPSetDescription(puPSet);
+  fillHistoPSetDescription(puPSet, 130, 0, 130);
   histoPSet.add<edm::ParameterSetDescription>("puPSet", puPSet);
 
+  edm::ParameterSetDescription lumiPSet;
+  fillHistoPSetDescription(lumiPSet, 5000, 0, 20000);
+  histoPSet.add<edm::ParameterSetDescription>("lumiPSet", lumiPSet);
+
   edm::ParameterSetDescription pixellumiPSet;
-  fillHistoPSetDescription(pixellumiPSet);
+  fillHistoPSetDescription(pixellumiPSet, 300, 0, 3);
   histoPSet.add<edm::ParameterSetDescription>("pixellumiPSet", pixellumiPSet);
 
-  edm::ParameterSetDescription lsPSet;
-  fillHistoLSPSetDescription(lsPSet);
-  histoPSet.add<edm::ParameterSetDescription>("lsPSet", lsPSet);
+  edm::ParameterSetDescription pixelClusterPSet;
+  fillHistoPSetDescription(pixelClusterPSet, 200, -0.5, 19999.5);
+  histoPSet.add("pixelClusterPSet", pixelClusterPSet);
 
   desc.add<edm::ParameterSetDescription>("histoPSet", histoPSet);