Merge pull request #36912 from bsunanda/Run3-alca216Y

Run3-alca216Y To make the response study work without HLT information if needed
cms-sw · Feb 11, 2022 · 4ee2652 · 4ee2652
2 parents 6a3b178 + 92bd73d
commit 4ee2652
Showing 1 changed file with 22 additions and 11 deletions.
diff --git a/Calibration/IsolatedParticles/plugins/StudyCaloResponse.cc b/Calibration/IsolatedParticles/plugins/StudyCaloResponse.cc
@@ -328,7 +328,11 @@ void StudyCaloResponse::analyze(edm::Event const& iEvent, edm::EventSetup const&
   bool ok(false);
   std::string triggerUse("None");
   if (!triggerEventHandle.isValid()) {
-    edm::LogWarning("IsoTrack") << "Error! Can't get the product " << triggerEvent_.label();
+    if (trigNames_.empty()) {
+      ok = true;
+    } else {
+      edm::LogWarning("StudyCaloResponse") << "Error! Can't get the product " << triggerEvent_.label();
+    }
   } else {
     triggerEvent = *(triggerEventHandle.product());
 
@@ -407,6 +411,21 @@ void StudyCaloResponse::analyze(edm::Event const& iEvent, edm::EventSetup const&
     edm::LogVerbatim("IsoTrack") << "Trigger check gives " << ok << " with " << triggerUse;
 
   //Look at the tracks
+  edm::Handle<reco::TrackCollection> trkCollection;
+  iEvent.getByToken(tok_genTrack_, trkCollection);
+
+  edm::Handle<reco::MuonCollection> muonEventHandle;
+  iEvent.getByToken(tok_Muon_, muonEventHandle);
+
+  edm::Handle<reco::VertexCollection> recVtxs;
+  iEvent.getByToken(tok_recVtx_, recVtxs);
+
+  if ((!trkCollection.isValid()) || (!muonEventHandle.isValid()) || (!recVtxs.isValid())) {
+    edm::LogWarning("StudyCaloResponse") << "Track collection " << trkCollection.isValid() << " Muon collection "
+                                         << muonEventHandle.isValid() << " Vertex Collecttion " << recVtxs.isValid();
+    ok = false;
+  }
+
   if (ok) {
     h_goodRun->Fill(RunNo);
     tr_goodRun = RunNo;
@@ -417,10 +436,8 @@ void StudyCaloResponse::analyze(edm::Event const& iEvent, edm::EventSetup const&
     const MagneticField* bField = &iSetup.getData(tok_magField_);
     const EcalChannelStatus* theEcalChStatus = &iSetup.getData(tok_ecalChStatus_);
 
-    edm::Handle<reco::VertexCollection> recVtxs;
-    iEvent.getByToken(tok_recVtx_, recVtxs);
-    int ntrk(0), ngoodPV(0), nPV(-1);
-    int nvtxs = (int)(recVtxs->size());
+    int ntrk(0), ngoodPV(0), nPV(-1), nvtxs(0);
+    nvtxs = (int)(recVtxs->size());
     for (int ind = 0; ind < nvtxs; ind++) {
       if (!((*recVtxs)[ind].isFake()) && (*recVtxs)[ind].ndof() > 4)
         ngoodPV++;
@@ -453,12 +470,6 @@ void StudyCaloResponse::analyze(edm::Event const& iEvent, edm::EventSetup const&
         tr_eventWeight = 0;
     }
 
-    edm::Handle<reco::TrackCollection> trkCollection;
-    iEvent.getByToken(tok_genTrack_, trkCollection);
-
-    edm::Handle<reco::MuonCollection> muonEventHandle;
-    iEvent.getByToken(tok_Muon_, muonEventHandle);
-
     //=== genParticle information
     edm::Handle<reco::GenParticleCollection> genParticles;
     iEvent.getByToken(tok_parts_, genParticles);