fix llvm10 warning: avoid creating a copy

cms-sw · Apr 28, 2020 · 2d9f8ab · 2d9f8ab
1 parent b9bf1bc
commit 2d9f8ab
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 6 deletions.
diff --git a/RecoLocalTracker/SiStripZeroSuppression/plugins/SiStripZeroSuppression.cc b/RecoLocalTracker/SiStripZeroSuppression/plugins/SiStripZeroSuppression.cc
@@ -164,7 +164,7 @@ inline edm::DetSet<SiStripRawDigi> SiStripZeroSuppression::formatRawDigis(const
   outRawDigis.reserve(rawDigis.size());
   const std::vector<bool>& apvf = algorithms->getAPVFlags();
   uint32_t strip = 0;
-  for (const auto rawDigi : rawDigis) {
+  for (const auto& rawDigi : rawDigis) {
     int16_t apvN = strip / 128;
     if (apvf[apvN])
       outRawDigis.push_back(rawDigi);

diff --git a/RecoLocalTracker/SiStripZeroSuppression/test/SiStripMergeZeroSuppression.cc b/RecoLocalTracker/SiStripZeroSuppression/test/SiStripMergeZeroSuppression.cc
@@ -99,7 +99,7 @@ void SiStripMergeZeroSuppression::produce(edm::Event& event, const edm::EventSet
             LogTrace("SiStripMergeZeroSuppression::produce") << "inserting only the digis for not restored APVs"
                                                              << "\n";
             LogTrace("SiStripMergeZeroSuppression::produce") << "size : " << zsModule->size() << "\n";
-            for (const auto itZsMod : *zsModule) {
+            for (const auto& itZsMod : *zsModule) {
               const uint16_t adc = itZsMod.adc();
               const uint16_t strip = itZsMod.strip();
               if (!restoredAPV[strip / 128]) {
@@ -115,7 +115,7 @@ void SiStripMergeZeroSuppression::produce(edm::Event& event, const edm::EventSet
           LogTrace("SiStripMergeZeroSuppression::produce") << "inserting only the digis for the restored APVs"
                                                            << "\n";
           LogTrace("SiStripMergeZeroSuppression::produce") << "size : " << suppressedDigis.size() << "\n";
-          for (const auto itSuppDigi : suppressedDigis) {
+          for (const auto& itSuppDigi : suppressedDigis) {
             const uint16_t adc = itSuppDigi.adc();
             const uint16_t strip = itSuppDigi.strip();
             if (restoredAPV[strip / 128]) {

diff --git a/RecoMuon/MuonIdentification/plugins/MuonIdProducer.cc b/RecoMuon/MuonIdentification/plugins/MuonIdProducer.cc
@@ -445,7 +445,7 @@ void MuonIdProducer::produce(edm::Event& iEvent, const edm::EventSetup& iSetup)
 
   // muons first - no cleaning, take as is.
   if (muonCollectionHandle_.isValid()) {
-    for (const auto muon : *muonCollectionHandle_) {
+    for (const auto& muon : *muonCollectionHandle_) {
       outputMuons->push_back(muon);
     }
   }

diff --git a/RecoTracker/TkTrackingRegions/plugins/PixelInactiveAreaFinder.cc b/RecoTracker/TkTrackingRegions/plugins/PixelInactiveAreaFinder.cc
@@ -119,7 +119,7 @@ namespace {
     Stream ss;
     for (auto const& spansLayers : spansLayerSets) {
       ss << "Overlapping detGroups:\n";
-      for (auto const cspan : spansLayers.first) {
+      for (auto const& cspan : spansLayers.first) {
         detGroupSpanInfo(cspan, ss);
         ss << std::endl;
       }

diff --git a/RecoTracker/TrackProducer/interface/TrackProducerAlgorithm.icc b/RecoTracker/TrackProducer/interface/TrackProducerAlgorithm.icc
@@ -43,7 +43,7 @@ void TrackProducerAlgorithm<T>::runWithCandidate(const TrackingGeometry* theG,
 
   int cont = 0;
   int ntc = 0;
-  for (auto const theTC : theTCCollection) {
+  for (auto const& theTC : theTCCollection) {
     PTrajectoryStateOnDet const& state = theTC.trajectoryStateOnDet();
     const TrackCandidate::range& recHitVec = theTC.recHits();
     const TrajectorySeed& seed = theTC.seed();