Skip to content

Commit

Permalink
Fixed namin of inclusion guards an removed Phase1 from names
Browse files Browse the repository at this point in the history
  • Loading branch information
dmeuser committed Jun 2, 2021
1 parent 45d54f9 commit 208fc22
Show file tree
Hide file tree
Showing 6 changed files with 28 additions and 28 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
+ SiPixelPhase1RawDataHarvester
+ RunQTests_offline
+ SiPixelPhase1SummaryOffline
+ SiPixelPhase1BarycenterOffline
+ SiPixelBarycenterOffline
)

siPixelPhase1OfflineDQM_harvesting_cosmics = siPixelPhase1OfflineDQM_harvesting.copyAndExclude([
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
#Summary maps
from DQM.SiPixelPhase1Summary.SiPixelPhase1Summary_cfi import *
#Barycenter plots
from DQM.SiPixelPhase1Summary.SiPixelPhase1Barycenter_cfi import *
from DQM.SiPixelPhase1Summary.SiPixelBarycenter_cfi import *

from RecoPixelVertexing.PixelLowPtUtilities.ClusterShapeHitFilterESProducer_cfi import *
from RecoLocalTracker.SiStripClusterizer.SiStripClusterChargeCut_cfi import *
Expand Down
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
#ifndef SiPixelPhase1Barycenter_SiPixelPhase1Barycenter_h
#define SiPixelPhase1Barycenter_SiPixelPhase1Barycenter_h
#ifndef DQM_SiPixelPhase1Summary_SiPixelBarycenter_h
#define DQM_SiPixelPhase1Summary_SiPixelBarycenter_h
// -*- C++ -*-
//
// Package: SiPixelPhase1Barycenter
// Class : SiPixelPhase1Barycenter
// Package: SiPixelPhase1Summary
// Class : SiPixelBarycenter
//
/**
Expand Down Expand Up @@ -31,10 +31,10 @@
#include "CondFormats/AlignmentRecord/interface/GlobalPositionRcd.h"
#include "CondFormats/Alignment/interface/Alignments.h"

class SiPixelPhase1Barycenter : public DQMEDHarvester {
class SiPixelBarycenter : public DQMEDHarvester {
public:
explicit SiPixelPhase1Barycenter(const edm::ParameterSet& conf);
~SiPixelPhase1Barycenter() override;
explicit SiPixelBarycenter(const edm::ParameterSet& conf);
~SiPixelBarycenter() override;

protected:
void beginRun(edm::Run const& run, edm::EventSetup const& eSetup) override;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#ifndef SiPixelPhase1Barycenter_SiPixelPhase1BarycenterHelper_h
#define SiPixelPhase1Barycenter_SiPixelPhase1BarycenterHelper_h
#ifndef DQM_SiPixelPhase1Summary_SiPixelBarycenterHelper_h
#define DQM_SiPixelPhase1Summary_SiPixelBarycenterHelper_h

#include "DataFormats/TrackerCommon/interface/TrackerTopology.h"
#include "FWCore/MessageLogger/interface/MessageLogger.h"
Expand Down Expand Up @@ -87,7 +87,7 @@ namespace DQMBarycenter {
{
for (const auto& ali : input) {
if (DetId(ali.rawId()).det() != DetId::Tracker) {
edm::LogWarning("SiPixelPhase1Barycenters::computeBarycenters")
edm::LogWarning("SiPixelBarycenters::computeBarycenters")
<< "Encountered invalid Tracker DetId:" << ali.rawId() << " " << DetId(ali.rawId()).det()
<< " is different from " << DetId::Tracker << " - terminating ";
assert(DetId(ali.rawId()).det() != DetId::Tracker);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,4 @@
# This object is used to make changes for different running scenarios
#

SiPixelPhase1BarycenterOffline = DQMEDHarvester("SiPixelPhase1Barycenter")
SiPixelBarycenterOffline = DQMEDHarvester("SiPixelBarycenter")
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
// -*- C++ -*-
//
// Package: SiPixelPhase1Barycenter
// Class: SiPixelPhase1Barycenter
// Package: SiPixelPhase1Summary
// Class: SiPixelBarycenter
//
/**\class
Description: Create the Phase 1 pixel barycenter plots
Description: Create the pixel barycenter plots
Implementation:
<Notes on implementation>
Expand All @@ -15,9 +15,9 @@
// Created: 26th May 2021
//
//
#include "DQM/SiPixelPhase1Summary/interface/SiPixelPhase1Barycenter.h"
#include "DQM/SiPixelPhase1Summary/interface/SiPixelBarycenter.h"
#include "FWCore/MessageLogger/interface/MessageLogger.h"
#include "DQM/SiPixelPhase1Summary/interface/SiPixelPhase1BarycenterHelper.h"
#include "DQM/SiPixelPhase1Summary/interface/SiPixelBarycenterHelper.h"
#include "CalibTracker/StandaloneTrackerTopology/interface/StandaloneTrackerTopology.h"

#include <string>
Expand All @@ -26,23 +26,23 @@
using namespace std;
using namespace edm;

SiPixelPhase1Barycenter::SiPixelPhase1Barycenter(const edm::ParameterSet& iConfig)
SiPixelBarycenter::SiPixelBarycenter(const edm::ParameterSet& iConfig)
: DQMEDHarvester(iConfig) {
LogInfo("PixelDQM") << "SiPixelPhase1Barycenter::SiPixelPhase1Barycenter: Got DQM BackEnd interface" << endl;
LogInfo("PixelDQM") << "SiPixelBarycenter::SiPixelBarycenter: Got DQM BackEnd interface" << endl;

}

SiPixelPhase1Barycenter::~SiPixelPhase1Barycenter() {
SiPixelBarycenter::~SiPixelBarycenter() {
// do anything here that needs to be done at desctruction time
// (e.g. close files, deallocate resources etc.)
LogInfo("PixelDQM") << "SiPixelPhase1Barycenter::~SiPixelPhase1Barycenter: Destructor" << endl;
LogInfo("PixelDQM") << "SiPixelBarycenter::~SiPixelBarycenter: Destructor" << endl;
}

void SiPixelPhase1Barycenter::beginRun(edm::Run const& run, edm::EventSetup const& eSetup) {}
void SiPixelBarycenter::beginRun(edm::Run const& run, edm::EventSetup const& eSetup) {}

void SiPixelPhase1Barycenter::dqmEndJob(DQMStore::IBooker& iBooker, DQMStore::IGetter& iGetter) {}
void SiPixelBarycenter::dqmEndJob(DQMStore::IBooker& iBooker, DQMStore::IGetter& iGetter) {}

void SiPixelPhase1Barycenter::dqmEndLuminosityBlock(DQMStore::IBooker& iBooker,
void SiPixelBarycenter::dqmEndLuminosityBlock(DQMStore::IBooker& iBooker,
DQMStore::IGetter& iGetter,
const edm::LuminosityBlock& lumiSeg,
edm::EventSetup const& c) {
Expand All @@ -62,7 +62,7 @@ void SiPixelPhase1Barycenter::dqmEndLuminosityBlock(DQMStore::IBooker& iBooker,
//------------------------------------------------------------------
// Used to book the barycenter histograms
//------------------------------------------------------------------
void SiPixelPhase1Barycenter::bookBarycenterHistograms(DQMStore::IBooker& iBooker) {
void SiPixelBarycenter::bookBarycenterHistograms(DQMStore::IBooker& iBooker) {
iBooker.cd();

iBooker.setCurrentFolder("PixelPhase1/Barycenter");
Expand All @@ -86,7 +86,7 @@ void SiPixelPhase1Barycenter::bookBarycenterHistograms(DQMStore::IBooker& iBooke
//------------------------------------------------------------------
// Fill the Barycenter histograms
//------------------------------------------------------------------
void SiPixelPhase1Barycenter::fillBarycenterHistograms(DQMStore::IBooker& iBooker, DQMStore::IGetter& iGetter, const std::vector<AlignTransform>& input, const std::vector<AlignTransform>& GPR) {
void SiPixelBarycenter::fillBarycenterHistograms(DQMStore::IBooker& iBooker, DQMStore::IGetter& iGetter, const std::vector<AlignTransform>& input, const std::vector<AlignTransform>& GPR) {

const auto GPR_translation_pixel = GPR[0].translation();
const std::map<DQMBarycenter::coordinate, float> GPR_pixel = {{DQMBarycenter::t_x, GPR_translation_pixel.x()}, {DQMBarycenter::t_y, GPR_translation_pixel.y()}, {DQMBarycenter::t_z, GPR_translation_pixel.z()}};
Expand All @@ -109,4 +109,4 @@ void SiPixelPhase1Barycenter::fillBarycenterHistograms(DQMStore::IBooker& iBooke
}

//define this as a plug-in
DEFINE_FWK_MODULE(SiPixelPhase1Barycenter);
DEFINE_FWK_MODULE(SiPixelBarycenter);

0 comments on commit 208fc22

Please sign in to comment.