Code checks implemented

cms-sw · Apr 28, 2023 · 1f328e1 · 1f328e1
1 parent 5e08da5
commit 1f328e1
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/EventFilter/HGCalRawToDigi/interface/HGCalModuleTreeReader.h b/EventFilter/HGCalRawToDigi/interface/HGCalModuleTreeReader.h
@@ -28,7 +28,7 @@ namespace hgcal::econd {
     struct HGCModuleTreeEvent {
       unsigned int event, chip;
       int half, bxcounter, eventcounter, orbitcounter, trigtime, trigwidth;
-      std::vector<unsigned int>* daqdata{0};
+      std::vector<unsigned int>* daqdata{nullptr};
     };
     ECONDInput next() override;
 

diff --git a/EventFilter/HGCalRawToDigi/plugins/HGCalRawToDigi.cc b/EventFilter/HGCalRawToDigi/plugins/HGCalRawToDigi.cc
@@ -83,11 +83,11 @@ void HGCalRawToDigi::produce(edm::Event& iEvent, const edm::EventSetup& iSetup)
     for (unsigned int i = 0; i < channeldata.size(); i++) {
       auto data = channeldata.at(i);
       auto cm = cms.at(i);
-      auto id = data.id();
+      const auto& id = data.id();
       auto idraw = id.raw();
       auto raw = data.raw();
       LogDebug("HGCalRawToDigi:produce") << "id=" << idraw << ", raw=" << raw << ", common mode index=" << cm << ".";
-      digis.push_back(HGCROCChannelDataFrameSpec(elecid_to_detid(data.id()), data.raw()));
+      digis.push_back(HGCROCChannelDataFrameSpec(elecid_to_detid(id), data.raw()));
       elec_digis.push_back(data);
     }
     if (const auto& bad_econds = unpacker_->badECOND(); !bad_econds.empty()) {

diff --git a/EventFilter/HGCalRawToDigi/plugins/HGCalSlinkEmulator.cc b/EventFilter/HGCalRawToDigi/plugins/HGCalSlinkEmulator.cc
@@ -143,7 +143,7 @@ void HGCalSlinkEmulator::produce(edm::Event& iEvent, const edm::EventSetup& iSet
 
   // store the emulation information if requested
   if (store_emul_info_)
-    iEvent.emplace(fedEmulInfoToken_, std::move(frame_gen_.lastSlinkEmulatedInfo()));
+    iEvent.emplace(fedEmulInfoToken_, frame_gen_.lastSlinkEmulatedInfo());
 }
 
 //