Fixed incorrect use of consumesCollector in FastTSGFromL2Muon

The function can ony be called in the constructor.
cms-sw · Sep 17, 2021 · 002868b · 002868b
1 parent e44a0d4
commit 002868b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/FastSimulation/Muons/plugins/FastTSGFromL2Muon.cc b/FastSimulation/Muons/plugins/FastTSGFromL2Muon.cc
@@ -17,7 +17,7 @@
 
 #include <set>
 
-FastTSGFromL2Muon::FastTSGFromL2Muon(const edm::ParameterSet& cfg) : theConfig(cfg) {
+FastTSGFromL2Muon::FastTSGFromL2Muon(const edm::ParameterSet& cfg) {
   produces<L3MuonTrajectorySeedCollection>();
 
   edm::ParameterSet serviceParameters = cfg.getParameter<edm::ParameterSet>("ServiceParameters");
@@ -28,15 +28,14 @@ FastTSGFromL2Muon::FastTSGFromL2Muon(const edm::ParameterSet& cfg) : theConfig(c
   theSeedCollectionLabels = cfg.getParameter<std::vector<edm::InputTag> >("SeedCollectionLabels");
   theSimTrackCollectionLabel = cfg.getParameter<edm::InputTag>("SimTrackCollectionLabel");
   // useTFileService_ = cfg.getUntrackedParameter<bool>("UseTFileService",false);
+  edm::ParameterSet regionBuilderPSet = cfg.getParameter<edm::ParameterSet>("MuonTrackingRegionBuilder");
+  theRegionBuilder = std::make_unique<MuonTrackingRegionBuilder>(regionBuilderPSet, consumesCollector());
 }
 
 FastTSGFromL2Muon::~FastTSGFromL2Muon() {}
 
 void FastTSGFromL2Muon::beginRun(edm::Run const& run, edm::EventSetup const& es) {
   //region builder
-  edm::ParameterSet regionBuilderPSet = theConfig.getParameter<edm::ParameterSet>("MuonTrackingRegionBuilder");
-  edm::ConsumesCollector iC = consumesCollector();
-  theRegionBuilder = new MuonTrackingRegionBuilder(regionBuilderPSet, iC);
 
   /*
   if(useTFileService_) {

diff --git a/FastSimulation/Muons/plugins/FastTSGFromL2Muon.h b/FastSimulation/Muons/plugins/FastTSGFromL2Muon.h
@@ -37,7 +37,6 @@ class FastTSGFromL2Muon : public edm::stream::EDProducer<> {
              const SimTrack& theSimTrack);
 
 private:
-  edm::ParameterSet theConfig;
   edm::InputTag theSimTrackCollectionLabel;
   edm::InputTag theL2CollectionLabel;
   std::vector<edm::InputTag> theSeedCollectionLabels;
@@ -46,7 +45,7 @@ class FastTSGFromL2Muon : public edm::stream::EDProducer<> {
 
   MuonServiceProxy* theService;
   double thePtCut;
-  MuonTrackingRegionBuilder* theRegionBuilder;
+  std::unique_ptr<MuonTrackingRegionBuilder> theRegionBuilder;
 
   // TH1F* h_nSeedPerTrack;
   // TH1F* h_nGoodSeedPerTrack;