Fix for edm class version check

[smuzaffar]

Make sure to fail the build process if EDM Class Version or EDM Class Transients checks fail

[cmsbuild]

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch scramv3.

@cmsbuild, @smuzaffar, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.
cms-bot commands are listed here

[smuzaffar]

please test

[cmsbuild]

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a74df0/22441/summary.html
COMMIT: bda452d
CMSSW: CMSSW_12_3_X_2022-02-14-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw-config/89/22441/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @belforte update crab-prod to last tested crab-dev cmsdist#7625
• @cms-sw Update tag for RecoMuon-MuonIdentification to V01-13-00 cmsdist#7626
• @cms-sw [Coral] Add const to char* to fix compiler errors with PyString_AsString cmsdist#7622

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a74df0/22441/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a74df0/22441/git-merge-result

Build

I found compilation error when building:

>> Checking EDM Class Transients in libPhysicsToolsFWLite.so
@@@@ ----> OK  EDM Class Version 
>> Checking EDM Class Transients in libDataFormatsHLTReco.so
@@@@ ----> OK  EDM Class Version 
>> Checking EDM Class Transients in libCalibrationHcalCalibAlgos.so
error: class 'pat::Muon' has a different checksum for ClassVersion 29. Increment ClassVersion to 30 and assign it to checksum 4221614933
Suggestion: You can run 'scram build updateclassversion' to generate src/DataFormats/PatCandidates/src/classes_def_objects.xml.generated with updated ClassVersion
>> Checking EDM Class Version for src/DataFormats/PatCandidates/src/classes_def_trigger.xml in libDataFormatsPatCandidates.so
@@@@ ----> OK  EDM Class Version 
>> Checking EDM Class Transients in libPhysicsToolsPatUtils.so
Error in : Dictionary trigger function for DataFormatsPatCandidates_x3r not found


[cmsbuild]

Pull request #89 was updated.

[smuzaffar]

test parameters:

• addpkg = DataFormats

[smuzaffar]

please test

[smuzaffar]

+externals

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next scramv3 IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a74df0/22454/summary.html
COMMIT: c7f9d83
CMSSW: CMSSW_12_3_X_2022-02-15-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw-config/89/22454/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-a74df0/138.4_PromptCollisions+RunMinimumBias2021+ALCARECOPROMPTR3+HARVESTDPROMPTR3
• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-a74df0/138.5_ExpressCollisions+RunMinimumBias2021+TIER0EXPRUN3+ALCARECOEXPR3+HARVESTDEXPR3
• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-a74df0/139.001_RunMinimumBias2021+RunMinimumBias2021+HLTDR3_2021+RECODR3_MinBiasOffline+HARVESTD2021MB

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3965143
• DQMHistoTests: Total failures: 13
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3965107
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 48 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 204 log files, 45 edm output root files, 49 DQM output files
• TriggerResults: no differences found