Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy all CFIPYTHON_PACKAGE_FILES files to cfipython store #104

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

smuzaffar
Copy link
Contributor

This change allows to copy any file, set via CFIPYTHON_PACKAGE_FILES project configuration` in to cfipython store. This is needed by cms-sw/cmssw#44396

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar for branch scramv3.

@cmsbuild, @smuzaffar, @iarspider, @aandvalenzuela can you please review it and eventually sign? Thanks.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 14, 2024

cms-bot internal usage

@smuzaffar
Copy link
Contributor Author

smuzaffar commented Mar 15, 2024

test parameters:

  • full_cmssw = true
  • skip_test = static,header

@smuzaffar
Copy link
Contributor Author

please test with cms-sw/cmssw#44396

@smuzaffar
Copy link
Contributor Author

+externals

@smuzaffar smuzaffar merged commit 2560c63 into scramv3 Mar 15, 2024
10 of 11 checks passed
@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next scramv3 IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: cms-sw/cmssw#44396

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-aef25c/38153/summary.html
COMMIT: ad41415
CMSSW: CMSSW_14_1_X_2024-03-14-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw-config/104/38153/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@smuzaffar smuzaffar deleted the cfipython-py-module branch March 28, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants