Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set crab-pre to what is prod ATM #9732

Merged
merged 2 commits into from
Mar 7, 2025

Conversation

belforte
Copy link
Contributor

@belforte belforte commented Mar 6, 2025

in preparation for moving from IB to main CVMFS
FYI @sinonkt

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2025

A new Pull Request was created by @belforte for branch IB/CMSSW_15_1_X/master.

@cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2025

cms-bot internal usage

@belforte belforte changed the title set crab-pr to what is prod ATM set crab-pre to what is prod ATM Mar 6, 2025
@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2025

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-47ca0c/44836/summary.html
COMMIT: 0b8ba7f
CMSSW: CMSSW_15_1_X_2025-03-06-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9732/44836/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building:

+ rm -fr /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/BUILDROOT/fbf37a83677c5668e6da746ca0c382e6/opt/cmssw/el8_amd64_gcc12/cms/crab-pre/v3.241125.00-fbf37a83677c5668e6da746ca0c382e6
+ '[' v3.241125.00-fbf37a83677c5668e6da746ca0c382e6 '!=' v3.241125.00 ']'
+ echo 'ERROR: v3.241125.00-fbf37a83677c5668e6da746ca0c382e6 not same as v3.241125.00. Automatic version suffix was added, please update the version explicitly for crab-pre.spec to avoid this error.'
ERROR: v3.241125.00-fbf37a83677c5668e6da746ca0c382e6 not same as v3.241125.00. Automatic version suffix was added, please update the version explicitly for crab-pre.spec to avoid this error.
+ exit 1
error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.Qzktfg (%prep)


RPM build errors:
line 35: It's not recommended to have unversioned Obsoletes: Obsoletes: cms+crab-pre+v3.241125.00-fbf37a83677c5668e6da746ca0c382e6
Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.Qzktfg (%prep)


@belforte
Copy link
Contributor Author

belforte commented Mar 6, 2025

@smuzaffar I am sorry if this is due to my trying basically roll back crab-pre to an earlier tag. I can surely change 00 suffix to 01 but am not sure that I understand correctly. Is that what I should do ?

@smuzaffar
Copy link
Contributor

smuzaffar commented Mar 6, 2025

@belforte , going back to an old version is not going to help. The way crab wrapper scripts work is that they search for greatest version and use it. so crab-pre is not going to pick up v3.241125 as newer tag e.g v3.241218 is already installed in ib area.

But if you want this for production cvmfs area which still has v3.241030.00 as latest crab-pre then yes just update the suffix

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2025

Pull request #9732 was updated.

@belforte
Copy link
Contributor Author

belforte commented Mar 7, 2025

thanks @smuzaffar . Yes, that's what I want, so I have updated the prefix. The problem here is that it has been too long since CRAB Client was updated in production and I got confused. Sorry for extra work for you.

@smuzaffar
Copy link
Contributor

please test

@smuzaffar
Copy link
Contributor

+externals

@smuzaffar smuzaffar merged commit a274e39 into cms-sw:IB/CMSSW_15_1_X/master Mar 7, 2025
11 of 12 checks passed
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2025

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_15_1_X/master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2025

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-47ca0c/44845/summary.html
COMMIT: 7c63222
CMSSW: CMSSW_15_1_X_2025-03-06-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9732/44845/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-47ca0c/44845/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-47ca0c/44845/git-merge-result

Comparison Summary

Summary:

  • You potentially added 15 lines to the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3920300
  • DQMHistoTests: Total failures: 21
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3920259
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 214 log files, 184 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants