-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dependency on CLUEstering #9604
base: IB/CMSSW_15_1_X/master
Are you sure you want to change the base?
Add dependency on CLUEstering #9604
Conversation
A new Pull Request was created by @sbaldu for branch IB/CMSSW_15_0_X/master. @cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks. |
cms-bot internal usage |
Pull request #9604 was updated. |
Pull request #9604 was updated. |
@sbaldu , this is a new external, can you please open a github issue at https://github.com/cms-sw/cmssw/issues with details e.g. why it is needed and where it will be used? Note that we already have CLUE as externals ... is For new externals you also need to provide
|
I opened issue #9618. |
Pull request #9604 was updated. |
please test |
-1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-eb02ef/44424/summary.html External BuildI found compilation warning when building: See details on the summary page. |
please test |
Pull request #9604 was updated. |
-1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-eb02ef/44425/summary.html External BuildI found compilation warning when building: See details on the summary page. |
Pull request #9604 was updated. |
-1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-eb02ef/44426/summary.html External BuildI found compilation error when building: -rw-rw-r-- root/root 1380 2025-02-10 20:58 CLUEstering-2.5.0/setup.py + STATUS=0 + '[' 0 -ne 0 ']' + cd 'CLUEstering-%{git_commit}' /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.N2JV77: line 39: cd: CLUEstering-%{git_commit}: No such file or directory error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.N2JV77 (%prep) RPM build errors: line 36: It's not recommended to have unversioned Obsoletes: Obsoletes: external+CLUEstering+2.5.0-fcd8ddfd37e158509b8511b32c647514 Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.N2JV77 (%prep) |
please test |
Pull request #9604 was updated. |
-1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-eb02ef/44429/summary.html |
please test |
Pull request #9604 was updated. |
Just to note that my questions in cms-sw/cmssw#47125 (comment) are still unanswered. Closest to technical standpoint, I think, the question on license should be resolved before merging this PR. |
hold |
Pull request has been put on hold by @smuzaffar |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-eb02ef/44434/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: You can see more details here: Comparison SummarySummary:
|
Pull request #9604 was updated. |
Pull request #9604 was updated. |
This PR adds the CLUEstering library as an external dependency.