Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependency on CLUEstering #9604

Open
wants to merge 12 commits into
base: IB/CMSSW_15_1_X/master
Choose a base branch
from

Conversation

sbaldu
Copy link

@sbaldu sbaldu commented Jan 9, 2025

This PR adds the CLUEstering library as an external dependency.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 9, 2025

A new Pull Request was created by @sbaldu for branch IB/CMSSW_15_0_X/master.

@cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 9, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

Pull request #9604 was updated.

@cmsbuild
Copy link
Contributor

Pull request #9604 was updated.

@smuzaffar
Copy link
Contributor

@sbaldu , this is a new external, can you please open a github issue at https://github.com/cms-sw/cmssw/issues with details e.g. why it is needed and where it will be used?

Note that we already have CLUE as externals ... is CLUEsteing has any deps on CLUE ?

For new externals you also need to provide

@sbaldu
Copy link
Author

sbaldu commented Jan 16, 2025

I opened issue #9618.

@cmsbuild
Copy link
Contributor

Pull request #9604 was updated.

@smuzaffar smuzaffar changed the base branch from IB/CMSSW_15_0_X/master to IB/CMSSW_15_1_X/master February 7, 2025 08:45
@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-eb02ef/44424/summary.html
COMMIT: a518239
CMSSW: CMSSW_15_1_X_2025-02-17-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9604/44424/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation warning when building: See details on the summary page.

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

Pull request #9604 was updated.

@cmsbuild
Copy link
Contributor

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-eb02ef/44425/summary.html
COMMIT: 6b88f9e
CMSSW: CMSSW_15_1_X_2025-02-17-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9604/44425/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation warning when building: See details on the summary page.

@cmsbuild
Copy link
Contributor

Pull request #9604 was updated.

@cmsbuild
Copy link
Contributor

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-eb02ef/44426/summary.html
COMMIT: 6e8b343
CMSSW: CMSSW_15_1_X_2025-02-17-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9604/44426/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building:

-rw-rw-r-- root/root      1380 2025-02-10 20:58 CLUEstering-2.5.0/setup.py
+ STATUS=0
+ '[' 0 -ne 0 ']'
+ cd 'CLUEstering-%{git_commit}'
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.N2JV77: line 39: cd: CLUEstering-%{git_commit}: No such file or directory
error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.N2JV77 (%prep)


RPM build errors:
line 36: It's not recommended to have unversioned Obsoletes: Obsoletes: external+CLUEstering+2.5.0-fcd8ddfd37e158509b8511b32c647514
Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.N2JV77 (%prep)


@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

Pull request #9604 was updated.

@cmsbuild
Copy link
Contributor

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-eb02ef/44429/summary.html
COMMIT: 9a80abc
CMSSW: CMSSW_15_1_X_2025-02-17-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9604/44429/install.sh to create a dev area with all the needed externals and cmssw changes.

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

Pull request #9604 was updated.

@makortel
Copy link
Contributor

Just to note that my questions in cms-sw/cmssw#47125 (comment) are still unanswered.

Closest to technical standpoint, I think, the question on license should be resolved before merging this PR.

@smuzaffar
Copy link
Contributor

hold

@cmsbuild
Copy link
Contributor

Pull request has been put on hold by @smuzaffar
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@cmsbuild cmsbuild added the hold label Feb 17, 2025
@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-eb02ef/44434/summary.html
COMMIT: 204ed21
CMSSW: CMSSW_15_1_X_2025-02-17-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9604/44434/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-eb02ef/44434/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-eb02ef/44434/git-merge-result

Comparison Summary

Summary:

  • You potentially added 21 lines to the logs
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3905432
  • DQMHistoTests: Total failures: 58
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3905354
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 214 log files, 184 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@cmsbuild
Copy link
Contributor

Pull request #9604 was updated.

@cmsbuild
Copy link
Contributor

Pull request #9604 was updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants