Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated root to tip of branch v6-32-00-patches #9442

Conversation

iarspider
Copy link
Contributor

Changes: link - roofit and jsroot.

@iarspider
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 1, 2024

A new Pull Request was created by @iarspider for branch IB/CMSSW_14_2_X/root632.

@aandvalenzuela, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 1, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 1, 2024

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4c798b/41825/summary.html
COMMIT: 091d615
CMSSW: CMSSW_14_2_ROOT632_X_2024-09-30-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9442/41825/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test test_G2GainsValidator had ERRORS

Comparison Summary

Summary:

@smuzaffar
Copy link
Contributor

+externals

unit test failure is not related to this change

@smuzaffar smuzaffar merged commit 3f0e3fd into cms-sw:IB/CMSSW_14_2_X/root632 Oct 1, 2024
8 of 9 checks passed
@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 1, 2024

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_14_2_X/root632 IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants