Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14_0_X] Update L1Trigger-L1TMuon tag #9235

Merged

Conversation

aloeliger
Copy link
Contributor

Updates muon tag as done in https://github.com/cms-sw/cmsdist/pull/9226/files as requested. This should update the L1Muon data repository for L1Muon backport PR cms-sw/cmssw#45107

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @aloeliger for branch IB/CMSSW_14_0_X/master.

@smuzaffar, @cmsbuild, @iarspider, @aandvalenzuela can you please review it and eventually sign? Thanks.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 11, 2024

cms-bot internal usage

@aloeliger aloeliger changed the title Update L1Trigger-L1TMuon tag [14_0_X] Update L1Trigger-L1TMuon tag Jun 11, 2024
@aloeliger
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-28fae1/39835/summary.html
COMMIT: 7d93656
CMSSW: CMSSW_14_0_X_2024-06-11-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9235/39835/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@smuzaffar
Copy link
Contributor

+externals

only adds new data files ( https://github.com/cms-data/L1Trigger-L1TMuon/pull/28/files ). This should go with cms-sw/cmssw#45107

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_14_0_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@missirol
Copy link

missirol commented Jul 1, 2024

I'm confused. cms-sw/cmssw#45107 was said to depend on this PR, but the former was merged 3 weeks ago, while the latter (this one) is still not merged.

Should this be included in the next 14_0_X release ?

@aloeliger
Copy link
Contributor Author

@missirol My understanding is yes.

@smuzaffar
Copy link
Contributor

@cms-sw/orp-l2 , I am merging this for 14.0.X as this was needed by cms-sw/cmssw#45107 which was merged 3 weeks ago

@smuzaffar smuzaffar merged commit 1be66d5 into cms-sw:IB/CMSSW_14_0_X/master Jul 2, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants